Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAMF Protect] Adding System Tests #9673

Merged
merged 4 commits into from Apr 23, 2024

Conversation

txhaflaire
Copy link
Contributor

Type of change:

  • Enhancement

Proposed commit message

Implemented System Tests for end-to-end testing on new releases of the Jamf Protect integration.
System Tests are a requirement to make an integration generally available.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

elastic-package test system

--- Test results for package: jamf_protect - START ---
╭──────────────┬────────────────────┬───────────┬───────────────┬────────┬───────────────╮
│ PACKAGE      │ DATA STREAM        │ TEST TYPE │ TEST NAME     │ RESULT │  TIME ELAPSED │
├──────────────┼────────────────────┼───────────┼───────────────┼────────┼───────────────┤
│ jamf_protect │ alerts             │ system    │ http-endpoint │ PASS   │ 37.088778917s │
│ jamf_protect │ telemetry          │ system    │ http-endpoint │ PASS   │ 37.023085666s │
│ jamf_protect │ web_threat_events  │ system    │ http-endpoint │ PASS   │ 37.983495417s │
│ jamf_protect │ web_traffic_events │ system    │ http-endpoint │ PASS   │ 38.297262291s │
╰──────────────┴────────────────────┴───────────┴───────────────┴────────┴───────────────╯
--- Test results for package: jamf_protect - END   ---
Done

@txhaflaire txhaflaire requested a review from a team as a code owner April 23, 2024 08:27
@ShourieG
Copy link
Contributor

/test

@ShourieG
Copy link
Contributor

/test

@andrewkroh andrewkroh changed the title Adding System Tests [JAMF Protect] Adding System Tests Apr 23, 2024
@ShourieG
Copy link
Contributor

/test

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShourieG ShourieG merged commit 54bb873 into elastic:main Apr 23, 2024
5 checks passed
@elasticmachine
Copy link

Package jamf_protect - 0.5.0 containing this change is available at https://epr.elastic.co/search?package=jamf_protect

@txhaflaire txhaflaire deleted the jamf_protect_0.5.0 branch April 25, 2024 07:43
gizas pushed a commit that referenced this pull request Apr 26, 2024
* Adding System Tests

* Update changelog.yml

* Fixed input.datset as that got reverted by resolving a merge conflict

* Synced readme and re-run system tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants