New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packages/aws/data_stream/lambda: Add Async metrics #9782
Conversation
🚀 Benchmarks reportTo see the full report comment with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor nits and dashboard changes requested. Dashboard changes are not specific with the changes in this PR but they are kind of minor improvements which can be done alongside
packages/aws/kibana/dashboard/aws-7ac8e1d0-28d2-11ea-ba6c-49a884eb104f.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check all avg. Error average fields will have "per minute" in the definition as the aggregates are done on one-minute intervals.
Please check unchanged avg fields if they have the average mentioned in their description.
- name: AsyncEventsReceived.sum | ||
type: long | ||
metric_type: gauge | ||
description: The number of events that Lambda successfully queues for processing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: The number of events that Lambda successfully queues for processing. | |
description: The number of asynchronous events that Lambda successfully adds to the function event queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing came to my mind seeing the updated screenshot. For visualizations Async Event Wait
and Async Events Received
their @timestamp
interval is set to Auto
which is correct and the timestamp per x mins/secs/hours
would change dynamically as per the duration selected above. However for Top Errors
and Lambda Function Duration
same is not reflected. Can we check there if something else is set in there?
This is not true. The blog was merely mentioning on how the in-built cloud watch dashboard is built on. In elastic integration, the user has the flexibility to choose the |
Got it. Then let's not add the per minute change I suggested. Or we can replace "per minute" to "per configured period". Is it by default 1m? |
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded
History
cc @agithomas |
Quality Gate passedIssues Measures |
Package aws - 2.15.0 containing this change is available at https://epr.elastic.co/search?package=aws |
Proposed commit message
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Screenshots