-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build apache integration #98
Conversation
Currently blocked by: elastic/kibana#69677 |
The integration is finished. All dashboards are presenting data. @ruflin few questions here:
|
|
Pinging @elastic/integrations (Team:Integrations) |
@@ -46,6 +46,6 @@ datasources: | |||
required: true | |||
show_user: true | |||
default: | |||
- http://127.0.0.1 | |||
- http://127.0.0.1:80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this change intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intended to slightly suggest that it's possible to configure a port. I can clean this one if it's better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a question on the NGINX change but this LGTM
* Import apache modules * Build similarly to nginx * Add template for README * Add README * Clean up fields * Fix docs header * Fix bugs * Add missing fields to README * Add sample event * Bump up version to 0.1.0 * Remove os related variables * Fix: properties order
This PR migrates apache modules to the integration.
Screenshots: