Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Universal profiling collector] use secrets variables #9806

Merged
merged 4 commits into from
May 8, 2024

Conversation

endorama
Copy link
Member

@endorama endorama commented May 7, 2024

Proposed commit message

Use secrets variables in Universal Profiling Collector manifest, following guidelines from #8610.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • [N/A] I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Align with suggestion from #8610
Add secret: true to secrets field in manifest
@endorama endorama marked this pull request as ready for review May 7, 2024 09:04
@endorama endorama requested a review from a team as a code owner May 7, 2024 09:04
@endorama endorama requested a review from a team May 7, 2024 09:06
Copy link
Member

@florianl florianl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍 the failing CI part - could not find Docker Compose configuration file - looks unrelated to me.

@endorama
Copy link
Member Author

endorama commented May 8, 2024

@florianl there was linter failure hidden in the output 😓

Error: checking package failed: linting package failed: found 1 validation error:
2024-05-07 11:08:14 CEST	   1. file "/opt/buildkite-agent/builds/bk-agent-prod-gcp-1715072633314993184/elastic/integrations/packages/universal_profiling_collector/manifest.yml" is invalid: field owner: type is required

Fixed in the latest commit

endorama added a commit to elastic/kibana that referenced this pull request May 8, 2024
Update profiler collector and symbolizer from elastic/integrations#9806 and elastic/integrations#9807
@elasticmachine
Copy link

💚 Build Succeeded

History

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@endorama endorama merged commit 188bf87 into main May 8, 2024
5 checks passed
@endorama endorama deleted the prof-collector-secrets branch May 8, 2024 12:24
@elasticmachine
Copy link

Package profiler_collector - 8.14.0 containing this change is available at https://epr.elastic.co/search?package=profiler_collector

endorama added a commit to elastic/kibana that referenced this pull request May 8, 2024
Update profiler collector and symbolizer from elastic/integrations#9806 and elastic/integrations#9807
endorama added a commit to elastic/kibana that referenced this pull request May 9, 2024
endorama added a commit that referenced this pull request May 13, 2024
endorama added a commit that referenced this pull request May 14, 2024
endorama added a commit that referenced this pull request May 14, 2024
endorama added a commit that referenced this pull request May 14, 2024
* Revert "[Universal profiling collector] use secrets variables (#9806)"

This reverts commit 188bf87.

* restore 8.14.0 changelog

* bump to 8.14.1 + changelog
bmorelli25 pushed a commit to bmorelli25/integrations that referenced this pull request Jun 3, 2024
* update format_version to 3.0.2

Align with suggestion from elastic#8610

* set secrets: true

Add secret: true to secrets field in manifest

* add changelog; bump to 8.14.0

* provide owner.type

See https://github.com/elastic/package-spec/blob/ee5775911d6764804548f1f47b479877fbd88d7e/spec/integration/manifest.spec.yml#L285
bmorelli25 pushed a commit to bmorelli25/integrations that referenced this pull request Jun 3, 2024
…tic#9855)

* Revert "[Universal profiling collector] use secrets variables (elastic#9806)"

This reverts commit 188bf87.

* restore 8.14.0 changelog

* bump to 8.14.1 + changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants