Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add files necesary for Metricbeat config #51

Merged
merged 9 commits into from
Feb 24, 2021
Merged

Add files necesary for Metricbeat config #51

merged 9 commits into from
Feb 24, 2021

Conversation

marius-dr
Copy link
Member

@marius-dr marius-dr commented Feb 4, 2021 •
edited
Loading

This PR adds the files necessary for elastic/kibana#90290

What's left to do after we confirm this works is the VAULT config for username/password in metricbeat.yml

  • DONE

Part of #39

@marius-dr
Copy link
Member Author

@dmlemeshko if you can review the conflict merge specifically, that would be great.

dmlemeshko
dmlemeshko approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmlemeshko dmlemeshko merged commit d12845e into master Feb 24, 2021
@dmlemeshko dmlemeshko deleted the add_monitoring branch February 25, 2021 18:09
@dmlemeshko dmlemeshko restored the add_monitoring branch February 25, 2021 18:09
@dmlemeshko dmlemeshko deleted the add_monitoring branch March 27, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlemeshko dmlemeshko dmlemeshko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marius-dr @dmlemeshko