use filter instead of reduce

elastic · Apr 30, 2020 · 03d0735 · 03d0735
1 parent 15001d4
commit 03d0735
Showing 1 changed file with 4 additions and 12 deletions.
diff --git a/...ins/ingest_manager/public/applications/ingest_manager/sections/epm/screens/home/index.tsx b/...ins/ingest_manager/public/applications/ingest_manager/sections/epm/screens/home/index.tsx
@@ -77,17 +77,9 @@ function InstalledPackages() {
       ? allPackages.response.filter(pkg => pkg.status === 'installed')
       : [];
 
-  const updatablePackages = allInstalledPackages.reduce<PackageListItem[]>((acc, item) => {
-    if ('savedObject' in item) {
-      if (item.version > item.savedObject.attributes.version) {
-        return acc.concat(item);
-      }
-    }
-    return acc;
-  }, []);
-
-  const packages =
-    selectedCategory === 'updates_available' ? [...updatablePackages] : [...allInstalledPackages];
+  const updatablePackages = allInstalledPackages.filter(
+    item => 'savedObject' in item && item.version > item.savedObject.attributes.version
+  );
 
   const categories = [
     {
@@ -119,7 +111,7 @@ function InstalledPackages() {
       isLoading={isLoadingPackages}
       controls={controls}
       title={title}
-      list={packages}
+      list={selectedCategory === 'updates_available' ? updatablePackages : allInstalledPackages}
     />
   );
 }