fix help text

elastic · Dec 8, 2020 · 05605de · 05605de
1 parent ec343c8
commit 05605de
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 18 deletions.
diff --git a/x-pack/plugins/runtime_fields/public/components/runtime_field_form/runtime_field_form.tsx b/x-pack/plugins/runtime_fields/public/components/runtime_field_form/runtime_field_form.tsx
@@ -5,6 +5,7 @@
  */
 import React, { useEffect, useState, useCallback } from 'react';
 import { i18n } from '@kbn/i18n';
+import { FormattedMessage } from '@kbn/i18n/react';
 import { PainlessLang, PainlessContext } from '@kbn/monaco';
 import {
   EuiFlexGroup,
@@ -260,20 +261,24 @@ const RuntimeFieldFormComp = ({
               error={getErrorsMessages()}
               isInvalid={!isValid}
               helpText={
-                <EuiFlexGroup justifyContent="flexEnd">
-                  <EuiFlexItem grow={false}>
-                    <EuiLink
-                      href={links.runtimePainless}
-                      target="_blank"
-                      external
-                      data-test-subj="painlessSyntaxLearnMoreLink"
-                    >
-                      {i18n.translate('xpack.runtimeFields.form.script.learnMoreLinkText', {
-                        defaultMessage: 'Learn more about syntax.',
-                      })}
-                    </EuiLink>
-                  </EuiFlexItem>
-                </EuiFlexGroup>
+                <FormattedMessage
+                  id="xpack.runtimeFields.form.source.scriptFieldHelpText"
+                  defaultMessage="Runtime fields without a script retrieve values from a field with the same name in _source. If a field with the same name doesn’t exist, no values are returned when a search request includes the runtime field. {learnMoreLink}"
+                  values={{
+                    learnMoreLink: (
+                      <EuiLink
+                        href={links.runtimePainless}
+                        target="_blank"
+                        external
+                        data-test-subj="painlessSyntaxLearnMoreLink"
+                      >
+                        {i18n.translate('xpack.runtimeFields.form.script.learnMoreLinkText', {
+                          defaultMessage: 'Learn more about syntax.',
+                        })}
+                      </EuiLink>
+                    ),
+                  }}
+                />
               }
               fullWidth
             >

diff --git a/x-pack/plugins/runtime_fields/public/components/runtime_field_form/schema.ts b/x-pack/plugins/runtime_fields/public/components/runtime_field_form/schema.ts
@@ -45,10 +45,6 @@ export const schema: FormSchema<RuntimeField> = {
       label: i18n.translate('xpack.runtimeFields.form.defineFieldLabel', {
         defaultMessage: 'Define field (optional)',
       }),
-      helpText: i18n.translate('xpack.runtimeFields.form.source.scriptFieldHelpText', {
-        defaultMessage:
-          'Runtime fields without a script retrieve values from a field with the same name in _source. If a field with the same name doesn’t exist, no values are returned when a search request includes the runtime field.',
-      }),
     },
   },
 };