Use 64 exit code for CLI related errors. Close kbnServer if it fa…

…iled to start.
elastic · Aug 1, 2018 · 0b5e7be · 0b5e7be
1 parent 7ecbeee
commit 0b5e7be
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/src/core/cli/cli.ts b/src/core/cli/cli.ts
@@ -33,7 +33,7 @@ Specify --help for available options
 `);
   }
 
-  process.exit(reason === undefined ? 0 : 1);
+  process.exit(reason === undefined ? 0 : 64);
 };
 
 export const parseArgv = (argv: string[]): Arguments => {

diff --git a/src/core/cli/commands/serve.ts b/src/core/cli/commands/serve.ts
@@ -279,7 +279,7 @@ function handleServeCommand(cliArgs: Arguments, installationFeatures: Installati
           console.error(`\n${chalk.bgRed(chalk.white(' ERROR '))} ${reason}\n`);
         }
 
-        process.exit(reason === undefined ? 0 : 1);
+        process.exit(reason === undefined ? 0 : (reason as any).processExitCode || 1);
       },
     }
   );

diff --git a/src/core/server/legacy_compat/legacy_service.ts b/src/core/server/legacy_compat/legacy_service.ts
@@ -203,7 +203,12 @@ export class LegacyService implements CoreService {
       require(REPL_PATH).startRepl(this.kbnServer);
     }
 
-    await kbnServer.listen();
+    try {
+      await kbnServer.listen();
+    } catch (err) {
+      await kbnServer.close();
+      throw err;
+    }
 
     return kbnServer;
   }