Skip to content

Commit

Permalink
[ML] Fix field stats in Discover showing 0 sample count at times when…
Browse files Browse the repository at this point in the history
… switching data views (#172734)

## Summary

Previously, when switching data views in Discover, the expanded rows in
Field stats view was inconsistently showing 0 as the sample of documents
used. This PR fixes that issue.

Before:


https://github.com/elastic/kibana/assets/43350163/242207f1-347c-4829-b718-d4b76b58d6a9



After:



https://github.com/elastic/kibana/assets/43350163/89da4b42-9846-4076-a059-80917bbae7a0


### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces—unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes—Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
  • Loading branch information
qn895 and kibanamachine committed Dec 7, 2023
1 parent fd5256a commit 15abfec
Showing 1 changed file with 7 additions and 3 deletions.
Expand Up @@ -20,6 +20,8 @@ import {
import type { SavedSearch } from '@kbn/saved-search-plugin/public';
import { EuiFlexItem } from '@elastic/eui';
import { css } from '@emotion/react';
import useObservable from 'react-use/lib/useObservable';
import { of } from 'rxjs';
import { useDiscoverServices } from '../../../../hooks/use_discover_services';
import { FIELD_STATISTICS_LOADED } from './constants';
import type { DiscoverStateContainer } from '../../services/discover_state';
Expand Down Expand Up @@ -120,7 +122,9 @@ export const FieldStatisticsTable = (props: FieldStatisticsTableProps) => {
trackUiMetric,
searchSessionId,
} = props;
const totalHits$ = stateContainer?.dataState.data$.totalHits$;
const totalHits = useObservable(stateContainer?.dataState.data$.totalHits$ ?? of(undefined));
const totalDocuments = useMemo(() => totalHits?.result, [totalHits]);

const services = useDiscoverServices();
const [embeddable, setEmbeddable] = useState<
| ErrorEmbeddable
Expand Down Expand Up @@ -173,7 +177,7 @@ export const FieldStatisticsTable = (props: FieldStatisticsTableProps) => {
onAddFilter,
sessionId: searchSessionId,
fieldsToFetch: stateContainer?.dataState.data$.availableFields$?.getValue().fields,
totalDocuments: totalHits$ ? totalHits$.getValue()?.result : undefined,
totalDocuments,
samplingOption: {
mode: 'normal_sampling',
shardSize: 5000,
Expand All @@ -191,7 +195,7 @@ export const FieldStatisticsTable = (props: FieldStatisticsTableProps) => {
filters,
onAddFilter,
searchSessionId,
totalHits$,
totalDocuments,
stateContainer,
]);

Expand Down

0 comments on commit 15abfec

Please sign in to comment.