add last check date column

elastic · Jan 29, 2024 · 199ea53 · 199ea53
1 parent 984f6d0
commit 199ea53
Show file tree

Hide file tree

Showing 12 changed files with 44 additions and 1 deletion.
diff --git a/...cs_data_quality_dashboard/impl/data_quality/data_quality_panel/index_properties/index.tsx b/...cs_data_quality_dashboard/impl/data_quality/data_quality_panel/index_properties/index.tsx
@@ -262,6 +262,7 @@ const IndexPropertiesComponent: React.FC<Props> = ({
               markdownComments,
               pattern,
               sameFamily: indexSameFamily,
+              checkedAt: Date.now(),
             },
           },
         };

diff --git a/...lution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/pattern/helpers.ts b/...lution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/pattern/helpers.ts
@@ -172,6 +172,7 @@ export const getSummaryTableItems = ({
     pattern,
     patternDocsCount,
     sizeInBytes: getSizeInBytes({ stats, indexName }),
+    checkedAt: results?.[indexName]?.checkedAt,
   }));
 
   return orderBy([sortByColumn], [sortByDirection], summaryTableItems);

diff --git a/...ata_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/helpers.test.tsx b/...ata_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/helpers.test.tsx
@@ -143,6 +143,7 @@ describe('helpers', () => {
       pattern: 'auditbeat-*',
       patternDocsCount: 57410,
       sizeInBytes: 103344068,
+      checkedAt: Date.now(),
     };
 
     const hasIncompatible: IndexSummaryTableItem = {
@@ -188,6 +189,7 @@ describe('helpers', () => {
         },
         { field: 'ilmPhase', name: 'ILM Phase', sortable: true, truncateText: false },
         { field: 'sizeInBytes', name: 'Size', sortable: true, truncateText: false },
+        { field: 'checkedAt', name: 'Last check', sortable: true, truncateText: false },
       ]);
     });
 

diff --git a/...ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/helpers.tsx b/...ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/helpers.tsx
@@ -5,8 +5,9 @@
  * 2.0.
  */
 
-import type { EuiBasicTableColumn } from '@elastic/eui';
 import {
+  EuiBasicTableColumn,
+  EuiText,
   EuiBadge,
   EuiButtonIcon,
   EuiIcon,
@@ -17,6 +18,7 @@ import {
   RIGHT_ALIGNMENT,
 } from '@elastic/eui';
 import React from 'react';
+import moment from 'moment';
 import styled from 'styled-components';
 
 import { EMPTY_STAT, getIlmPhaseDescription, getIncompatibleStatColor } from '../../helpers';
@@ -41,6 +43,7 @@ export interface IndexSummaryTableItem {
   pattern: string;
   patternDocsCount: number;
   sizeInBytes: number;
+  checkedAt: number | undefined;
 }
 
 export const getResultToolTip = (incompatible: number | undefined): string => {
@@ -237,6 +240,17 @@ export const getSummaryTableColumns = ({
     sortable: true,
     truncateText: false,
   },
+  {
+    field: 'checkedAt',
+    name: i18n.LAST_CHECK,
+    render: (_, { checkedAt }) => (
+      <EuiText size="xs">
+        {moment(checkedAt).isValid() ? moment(checkedAt).fromNow() : EMPTY_STAT}
+      </EuiText>
+    ),
+    sortable: true,
+    truncateText: false,
+  },
 ];
 
 export const getShowPagination = ({

diff --git a/...data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/translations.ts b/...data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/translations.ts
@@ -111,6 +111,13 @@ export const SIZE = i18n.translate(
   }
 );
 
+export const LAST_CHECK = i18n.translate(
+  'securitySolutionPackages.ecsDataQualityDashboard.summaryTable.lastCheckColumn',
+  {
+    defaultMessage: 'Last check',
+  }
+);
+
 export const THIS_INDEX_HAS_NOT_BEEN_CHECKED = i18n.translate(
   'securitySolutionPackages.ecsDataQualityDashboard.summaryTable.thisIndexHasNotBeenCheckedTooltip',
   {

diff --git a/...k/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/helpers.test.ts b/...k/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/helpers.test.ts
@@ -102,6 +102,7 @@ describe('helpers', () => {
       ],
       pattern: 'auditbeat-*',
       sameFamily: 0,
+      checkedAt: Date.now(),
     };
 
     it('returns undefined when results is undefined', () => {
@@ -1193,6 +1194,7 @@ describe('helpers', () => {
           markdownComments: ['foo', 'bar', 'baz'],
           pattern: 'packetbeat-*',
           sameFamily: 0,
+          checkedAt: Date.now(),
         },
         '.ds-packetbeat-8.6.1-2023.02.04-000001': {
           docsCount: 1628343,
@@ -1203,6 +1205,7 @@ describe('helpers', () => {
           markdownComments: ['foo', 'bar', 'baz'],
           pattern: 'packetbeat-*',
           sameFamily: 0,
+          checkedAt: Date.now(),
         },
       };
 
@@ -1220,6 +1223,7 @@ describe('helpers', () => {
           markdownComments: ['foo', 'bar', 'baz'],
           pattern: 'auditbeat-*',
           sameFamily: 0,
+          checkedAt: Date.now(),
         },
         'auditbeat-custom-index-1': {
           docsCount: 4,
@@ -1230,6 +1234,7 @@ describe('helpers', () => {
           markdownComments: ['foo', 'bar', 'baz'],
           pattern: 'auditbeat-*',
           sameFamily: 0,
+          checkedAt: Date.now(),
         },
         'auditbeat-custom-empty-index-1': {
           docsCount: 0,
@@ -1240,6 +1245,7 @@ describe('helpers', () => {
           markdownComments: ['foo', 'bar', 'baz'],
           pattern: 'auditbeat-*',
           sameFamily: 0,
+          checkedAt: Date.now(),
         },
       };
 
@@ -1257,6 +1263,7 @@ describe('helpers', () => {
           markdownComments: ['foo', 'bar', 'baz'],
           pattern: 'auditbeat-*',
           sameFamily: 0,
+          checkedAt: Date.now(),
         },
         'auditbeat-custom-index-1': {
           docsCount: 4,
@@ -1267,6 +1274,7 @@ describe('helpers', () => {
           markdownComments: ['foo', 'bar', 'baz'],
           pattern: 'auditbeat-*',
           sameFamily: 0,
+          checkedAt: Date.now(),
         },
         'auditbeat-custom-empty-index-1': {
           docsCount: 0,
@@ -1277,6 +1285,7 @@ describe('helpers', () => {
           markdownComments: ['foo', 'bar', 'baz'],
           pattern: 'auditbeat-*',
           sameFamily: 0,
+          checkedAt: Date.now(),
         },
       };
 
@@ -1342,6 +1351,7 @@ describe('helpers', () => {
         markdownComments: ['foo', 'bar', 'baz'],
         pattern: 'packetbeat-*',
         sameFamily: 0,
+        checkedAt: Date.now(),
       };
 
       expect(getErrorSummary(resultWithError)).toEqual({

diff --git a/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/helpers.ts b/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/helpers.ts
@@ -454,6 +454,7 @@ export interface StorageResult {
   batchId: string;
   indexName: string;
   isCheckAll: boolean;
+  checkedAt: number;
   docsCount: number;
   totalFieldCount: number;
   ecsFieldCount: number;
@@ -483,6 +484,7 @@ export const formatStorageResult = ({
   batchId: report.batchId,
   indexName: result.indexName,
   isCheckAll: report.isCheckAll,
+  checkedAt: result.checkedAt,
   docsCount: result.docsCount ?? 0,
   totalFieldCount: partitionedFieldMetadata.all.length,
   ecsFieldCount: partitionedFieldMetadata.ecsCompliant.length,
@@ -514,6 +516,7 @@ export const formatResultFromStorage = ({
   indexName: storageResult.indexName,
   markdownComments: storageResult.markdownComments,
   sameFamily: storageResult.sameFamilyFieldCount,
+  checkedAt: storageResult.checkedAt,
   pattern,
 });
 

diff --git a/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/types.ts b/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/types.ts
@@ -107,6 +107,7 @@ export interface DataQualityCheckResult {
   markdownComments: string[];
   sameFamily: number | undefined;
   pattern: string;
+  checkedAt: number;
 }
 
 export interface PatternRollup {

diff --git a/...urity-solution/ecs_data_quality_dashboard/impl/data_quality/use_results_rollup/helpers.ts b/...urity-solution/ecs_data_quality_dashboard/impl/data_quality/use_results_rollup/helpers.ts
@@ -156,6 +156,7 @@ export const updateResultOnCheckCompleted = ({
             markdownComments,
             pattern,
             sameFamily,
+            checkedAt: Date.now(),
           },
         },
       },

diff --git a/x-pack/plugins/ecs_data_quality_dashboard/server/lib/data_stream/results_field_map.ts b/x-pack/plugins/ecs_data_quality_dashboard/server/lib/data_stream/results_field_map.ts
@@ -11,6 +11,7 @@ export const resultsFieldMap: FieldMap = {
   batchId: { type: 'keyword', required: true },
   indexName: { type: 'keyword', required: true },
   isCheckAll: { type: 'boolean', required: true },
+  checkedAt: { type: 'date', required: true },
   docsCount: { type: 'long', required: true },
   totalFieldCount: { type: 'long', required: true },
   ecsFieldCount: { type: 'long', required: true },

diff --git a/x-pack/plugins/ecs_data_quality_dashboard/server/routes/results/results.mock.ts b/x-pack/plugins/ecs_data_quality_dashboard/server/routes/results/results.mock.ts
@@ -11,6 +11,7 @@ export const resultDocument: ResultDocument = {
   batchId: '33d95427-1fd3-43c3-bdeb-74324533a31e',
   indexName: '.ds-logs-endpoint.alerts-default-2023.11.23-000001',
   isCheckAll: false,
+  checkedAt: 1637673600000,
   docsCount: 100,
   totalFieldCount: 1582,
   ecsFieldCount: 677,

diff --git a/x-pack/plugins/ecs_data_quality_dashboard/server/schemas/result.ts b/x-pack/plugins/ecs_data_quality_dashboard/server/schemas/result.ts
@@ -11,6 +11,7 @@ export const ResultDocument = t.type({
   batchId: t.string,
   indexName: t.string,
   isCheckAll: t.boolean,
+  checkedAt: t.number,
   docsCount: t.number,
   totalFieldCount: t.number,
   ecsFieldCount: t.number,