Skip to content

Commit

Permalink
Clean up more
Browse files Browse the repository at this point in the history
  • Loading branch information
Heenawter committed Oct 6, 2023
1 parent 7bbbfa3 commit 25b1bca
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 20 deletions.
Expand Up @@ -170,7 +170,6 @@ export const DashboardUnsavedListing = ({
}
setItems(newItems);
});

return () => {
canceled = true;
};
Expand Down
Expand Up @@ -232,7 +232,6 @@ export const useDashboardListingTable = ({
try {
const deleteStartTime = window.performance.now();

console.log('delete dashboards');
deleteDashboards(
dashboardsToDelete.map(({ id }) => {
dashboardBackup.clearState(id);
Expand Down
Expand Up @@ -83,7 +83,6 @@ export async function findDashboardById(
references: cachedDashboard.item.references,
};
}

/** Otherwise, fetch the dashboard from the content management client, add it to the cache, and return the result */
const response = await contentManagement.client
.get<DashboardCrudTypes['GetIn'], DashboardCrudTypes['GetOut']>({
Expand Down
Expand Up @@ -138,9 +138,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.visualize.gotoVisualizationLandingPage();
await PageObjects.header.waitUntilLoadingHasFinished();

await PageObjects.dashboard.navigateToApp();

await PageObjects.dashboard.loadSavedDashboard('few panels');
const currentPanelCount = await PageObjects.dashboard.getPanelCount();
expect(currentPanelCount).to.eql(unsavedPanelCount);
Expand Down
2 changes: 0 additions & 2 deletions test/functional/page_objects/common_page.ts
Expand Up @@ -278,10 +278,8 @@ export class CommonPageObject extends FtrService {
const alert = await this.browser.getAlert();
await alert?.accept();
await this.sleep(700);

this.log.debug('returned from get, calling refresh');
await this.browser.refresh();

let currentUrl = shouldLoginIfPrompted
? await this.loginIfPrompted(appUrl, insertTimestamp, disableWelcomePrompt)
: await this.browser.getCurrentUrl();
Expand Down
13 changes: 0 additions & 13 deletions test/functional/services/common/browser.ts
Expand Up @@ -518,22 +518,9 @@ class BrowserService extends FtrService {
* @return {Promise<void>}
*/
public async clearSessionStorage(): Promise<void> {
this.log.debug('!!!! clear session storage');
await this.driver.executeScript('return window.sessionStorage.clear();');
}

/**
* Get from the "session storage" by key
*
* @param {string} key
* @return {Promise<string>}
*/
public async getSessionStorageItem(key: string): Promise<string | null> {
return await this.driver.executeScript<string>(
`return window.sessionStorage.getItem("${key}");`
);
}

/**
* Get from the "local storage" by key
*
Expand Down

0 comments on commit 25b1bca

Please sign in to comment.