fix(NA): test run with lodash has

elastic · Apr 20, 2020 · 2764554 · 2764554
1 parent ac6c582
commit 2764554
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/x-pack/plugins/upgrade_assistant/server/lib/telemetry/usage_collector.ts b/x-pack/plugins/upgrade_assistant/server/lib/telemetry/usage_collector.ts
@@ -4,7 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { set } from 'lodash';
+import { has, set } from 'lodash';
 import {
   APICaller,
   ElasticsearchServiceStart,
@@ -85,11 +85,8 @@ export async function fetchUpgradeAssistantMetrics(
     }
 
     const telemetryObj = defaultTelemetrySavedObject;
-    Object.keys(defaultTelemetrySavedObject).forEach((key: string) => {
-      if (
-        !upgradeAssistantTelemetrySavedObjectAttrs.hasOwnProperty(key) ||
-        !upgradeAssistantTelemetrySavedObjectAttrs[key]
-      ) {
+    Object.keys(upgradeAssistantTelemetrySavedObjectAttrs).forEach((key: string) => {
+      if (!has(defaultTelemetrySavedObject, key)) {
         return;
       }