Merge branch 'master' into uptime-87170_migrate-to-typescript-project

.github/CODEOWNERS

@@ -150,6 +150,12 @@
 /src/legacy/server/warnings/ @elastic/kibana-operations
 /.ci/es-snapshots/ @elastic/kibana-operations
 /vars/ @elastic/kibana-operations
+/.bazelignore @elastic/kibana-operations
+/.bazeliskversion @elastic/kibana-operations
+/.bazelrc @elastic/kibana-operations
+/.bazelrc.common @elastic/kibana-operations
+/.bazelversion @elastic/kibana-operations
+/WORKSPACE.bazel @elastic/kibana-operations
 #CC# /packages/kbn-expect/ @elastic/kibana-operations
 
 # Quality Assurance

docs/user/alerting/geo-alert-types.asciidoc

@@ -1,19 +1,16 @@
 [role="xpack"]
-[[geo-alert-types]]
-== Geo alert types
+[[geo-alerting]]
+== Geo alerting
 
-Two additional stack alerts are available:
-<<alert-type-tracking-threshold>> and <<alert-type-tracking-containment>>.
+Alerting now includes one additional stack alert: <<alert-type-tracking-containment>>.
 
 As with other stack alerts, you need `all` access to the *Stack Alerts* feature
-to be able to create and edit either of the geo alerts.
+to be able to create and edit a geo alert.
 See <<kibana-feature-privileges, feature privileges>> for more information on configuring roles that provide access to this feature. 
 
 [float]
-=== Geo alert requirements
-
-To create either a *Tracking threshold* or a *Tracking containment* alert, the
-following requirements must be present:
+=== Geo alerting requirements
+To create a *Tracking containment* alert, the following requirements must be present:
 
 - *Tracks index or index pattern*: An index containing a `geo_point` field, `date` field,
 and some form of entity identifier. An entity identifier is a `keyword` or `number`
@@ -33,62 +30,12 @@ than the current time minus the amount of the interval. If data older than
 
 [float]
 === Creating a geo alert
-Both *threshold* and *containment* alerts can be created by clicking the *Create*
-button in the <<alert-management, alert management UI>>.
+Click the *Create* button in the <<alert-management, alert management UI>>.
 Complete the <<defining-alerts-general-details, general alert details>>.
-Select <<alert-type-tracking-threshold>> to generate an alert when an entity crosses a boundary, and you desire the
-ability to highlight lines of crossing on a custom map.
-Select
-<<alert-type-tracking-containment>> if an entity should send out constant alerts
-while contained within a boundary (this feature is optional) or if the alert is generally
-just more focused around activity when an entity exists within a shape.
 
 [role="screenshot"]
 image::images/alert-types-tracking-select.png[Choosing a tracking alert type]
 
-[NOTE]
-==================================================
-With recent advances in the alerting framework, most of the features
-available in Tracking threshold alerts can be replicated with just
-a little more work in Tracking containment alerts. The capabilities of Tracking
-threshold alerts may be deprecated or folded into Tracking containment alerts
-in the future.
-==================================================
-
-[float]
-[[alert-type-tracking-threshold]]
-=== Tracking threshold
-The Tracking threshold alert type runs an {es} query over indices, comparing the latest
-entity locations with their previous locations. In the event that an entity has crossed a
-boundary from the selected boundary index, an alert may be generated.
-
-[float]
-==== Defining the conditions
-Tracking threshold has a *Delayed evaluation offset* and 4 clauses that define the
-condition to detect, as well as 2 Kuery bars used to provide additional filtering
-context for each of the indices.
-
-[role="screenshot"]
-image::images/alert-types-tracking-threshold-conditions.png[Five clauses define the condition to detect]
-
-
-Delayed evaluation offset:: If a data source lags or is intermittent, you may supply
-an optional value to evaluate alert conditions following a fixed delay. For instance, if data
-is consistently indexed 5-10 minutes following its original timestamp, a *Delayed evaluation
-offset* of `10 minutes` would ensure that alertable instances are still captured.
-Index (entity):: This clause requires an *index or index pattern*, a *time field* that will be used for the *time window*, and a *`geo_point` field* for tracking.
-By:: This clause specifies the field to use in the previously provided
-*index or index pattern* for tracking Entities. An entity is a `keyword`
-or `number` field that consistently identifies the entity to be tracked. 
-When entity:: This clause specifies which crossing option to track. The values
-*Entered*, *Exited*, and *Crossed* can be selected to indicate which crossing conditions
-should trigger an alert. *Entered* alerts on entry into a boundary, *Exited* alerts on exit
-from a boundary, and *Crossed* alerts on all boundary crossings whether they be entrances
-or exits.
-Index (Boundary):: This clause requires an *index or index pattern*, a *`geo_shape` field*
-identifying boundaries, and an optional *Human-readable boundary name* for better alerting
-messages.
-
 [float]
 [[alert-type-tracking-containment]]
 === Tracking containment

package.json

@@ -714,7 +714,6 @@
     "leaflet": "1.5.1",
     "leaflet-draw": "0.4.14",
     "leaflet-responsive-popup": "0.6.4",
-    "leaflet-vega": "^0.8.6",
     "leaflet.heat": "0.2.0",
     "less": "npm:@elastic/less@2.7.3-kibana",
     "license-checker": "^16.0.0",
@@ -833,6 +832,7 @@
     "val-loader": "^1.1.1",
     "vega": "^5.19.1",
     "vega-lite": "^4.17.0",
+    "vega-spec-injector": "^0.0.2",
     "vega-schema-url-parser": "^2.1.0",
     "vega-tooltip": "^0.25.0",
     "venn.js": "0.2.20",

src/plugins/discover/public/application/angular/discover.js

@@ -22,7 +22,6 @@ import {
   syncQueryStateWithUrl,
 } from '../../../../data/public';
 import { getSortArray } from './doc_table';
-import * as columnActions from './doc_table/actions/columns';
 import indexTemplateLegacy from './discover_legacy.html';
 import { addHelpMenuToAppChrome } from '../components/help_menu/help_menu_util';
 import { discoverResponseHandler } from './response_handler';
@@ -43,13 +42,9 @@ import {
   setBreadcrumbsTitle,
 } from '../helpers/breadcrumbs';
 import { validateTimeRange } from '../helpers/validate_time_range';
-import { popularizeField } from '../helpers/popularize_field';
-import { getSwitchIndexPatternAppState } from '../helpers/get_switch_index_pattern_app_state';
 import { addFatalError } from '../../../../kibana_legacy/public';
-import { METRIC_TYPE } from '@kbn/analytics';
 import {
   DEFAULT_COLUMNS_SETTING,
-  MODIFY_COLUMNS_ON_SWITCH,
   SAMPLE_SIZE_SETTING,
   SEARCH_FIELDS_FROM_SOURCE,
   SEARCH_ON_PAGE_LOAD_SETTING,
@@ -69,12 +64,10 @@ const {
   chrome,
   data,
   history: getHistory,
-  indexPatterns,
   filterManager,
   timefilter,
   toastNotifications,
   uiSettings: config,
-  trackUiMetric,
 } = getServices();
 
 const fetchStatuses = {
@@ -292,21 +285,6 @@ function discoverController($route, $scope, Promise) {
     }
   );
 
-  $scope.setIndexPattern = async (id) => {
-    const nextIndexPattern = await indexPatterns.get(id);
-    if (nextIndexPattern) {
-      const nextAppState = getSwitchIndexPatternAppState(
-        $scope.indexPattern,
-        nextIndexPattern,
-        $scope.state.columns,
-        $scope.state.sort,
-        config.get(MODIFY_COLUMNS_ON_SWITCH),
-        $scope.useNewFieldsApi
-      );
-      await setAppState(nextAppState);
-    }
-  };
-
   // update data source when filters update
   subscriptions.add(
     subscribeWithScope(
@@ -327,6 +305,7 @@ function discoverController($route, $scope, Promise) {
     sampleSize: config.get(SAMPLE_SIZE_SETTING),
     timefield: getTimeField(),
     savedSearch: savedSearch,
+    services,
     indexPatternList: $route.current.locals.savedObjects.ip.list,
     config: config,
     setHeaderActionMenu: getHeaderActionMenuMounter(),
@@ -340,18 +319,8 @@ function discoverController($route, $scope, Promise) {
     requests: new RequestAdapter(),
   });
 
-  $scope.timefilterUpdateHandler = (ranges) => {
-    timefilter.setTime({
-      from: moment(ranges.from).toISOString(),
-      to: moment(ranges.to).toISOString(),
-      mode: 'absolute',
-    });
-  };
   $scope.minimumVisibleRows = 50;
   $scope.fetchStatus = fetchStatuses.UNINITIALIZED;
-  $scope.showSaveQuery = capabilities.discover.saveQuery;
-  $scope.showTimeCol =
-    !config.get('doc_table:hideTimeColumn', false) && $scope.indexPattern.timeFieldName;
 
   let abortController;
   $scope.$on('$destroy', () => {
@@ -495,12 +464,6 @@ function discoverController($route, $scope, Promise) {
         )
       );
 
-      $scope.changeInterval = (interval) => {
-        if (interval) {
-          setAppState({ interval });
-        }
-      };
-
       $scope.$watchMulti(
         ['rows', 'fetchStatus'],
         (function updateResultState() {
@@ -606,19 +569,6 @@ function discoverController($route, $scope, Promise) {
     }
   };
 
-  $scope.updateSavedQueryId = (newSavedQueryId) => {
-    if (newSavedQueryId) {
-      setAppState({ savedQuery: newSavedQueryId });
-    } else {
-      // remove savedQueryId from state
-      const state = {
-        ...appStateContainer.getState(),
-      };
-      delete state.savedQuery;
-      appStateContainer.set(state);
-    }
-  };
-
   function getDimensions(aggs, timeRange) {
     const [metric, agg] = aggs;
     agg.params.timeRange = timeRange;
@@ -752,65 +702,6 @@ function discoverController($route, $scope, Promise) {
     return Promise.resolve();
   };
 
-  $scope.setSortOrder = function setSortOrder(sort) {
-    setAppState({ sort });
-  };
-
-  // TODO: On array fields, negating does not negate the combination, rather all terms
-  $scope.filterQuery = function (field, values, operation) {
-    const { indexPattern } = $scope;
-
-    popularizeField(indexPattern, field.name, indexPatterns);
-    const newFilters = esFilters.generateFilters(
-      filterManager,
-      field,
-      values,
-      operation,
-      $scope.indexPattern.id
-    );
-    if (trackUiMetric) {
-      trackUiMetric(METRIC_TYPE.CLICK, 'filter_added');
-    }
-    return filterManager.addFilters(newFilters);
-  };
-
-  $scope.addColumn = function addColumn(columnName) {
-    const { indexPattern, useNewFieldsApi } = $scope;
-    if (capabilities.discover.save) {
-      popularizeField(indexPattern, columnName, indexPatterns);
-    }
-    const columns = columnActions.addColumn($scope.state.columns, columnName, useNewFieldsApi);
-    setAppState({ columns });
-  };
-
-  $scope.removeColumn = function removeColumn(columnName) {
-    const { indexPattern, useNewFieldsApi } = $scope;
-    if (capabilities.discover.save) {
-      popularizeField(indexPattern, columnName, indexPatterns);
-    }
-    const columns = columnActions.removeColumn($scope.state.columns, columnName, useNewFieldsApi);
-    // The state's sort property is an array of [sortByColumn,sortDirection]
-    const sort = $scope.state.sort.length
-      ? $scope.state.sort.filter((subArr) => subArr[0] !== columnName)
-      : [];
-    setAppState({ columns, sort });
-  };
-
-  $scope.moveColumn = function moveColumn(columnName, newIndex) {
-    const columns = columnActions.moveColumn($scope.state.columns, columnName, newIndex);
-    setAppState({ columns });
-  };
-
-  $scope.setColumns = function setColumns(columns) {
-    // remove first element of columns if it's the configured timeFieldName, which is prepended automatically
-    const actualColumns =
-      $scope.indexPattern.timeFieldName && $scope.indexPattern.timeFieldName === columns[0]
-        ? columns.slice(1)
-        : columns;
-    $scope.state = { ...$scope.state, columns: actualColumns };
-    setAppState({ columns: actualColumns });
-  };
-
   async function setupVisualization() {
     // If no timefield has been specified we don't create a histogram of messages
     if (!getTimeField()) return;

src/plugins/discover/public/application/angular/discover_legacy.html

@@ -8,27 +8,16 @@
     hits="hits"
     index-pattern="indexPattern"
     minimum-visible-rows="minimumVisibleRows"
-    on-add-column="addColumn"
-    on-add-filter="filterQuery"
-    on-move-column="moveColumn"
-    on-change-interval="changeInterval"
-    on-remove-column="removeColumn"
-    on-set-columns="setColumns"
     on-skip-bottom-button-click="onSkipBottomButtonClick"
-    on-sort="setSortOrder"
     opts="opts"
     reset-query="resetQuery"
     result-state="resultState"
     rows="rows"
     search-source="searchSource"
-    set-index-pattern="setIndexPattern"
-    show-save-query="showSaveQuery"
     state="state"
-    time-filter-update-handler="timefilterUpdateHandler"
     time-range="timeRange"
     top-nav-menu="topNavMenu"
     update-query="handleRefresh"
-    update-saved-query-id="updateSavedQueryId"
     use-new-fields-api="useNewFieldsApi"
     unmapped-fields-config="unmappedFieldsConfig"
   >