[Uptime] Fix flaky uptime overview page test (#54767)

* Fix flaky uptime overview page test.

* Increase timeout for url checks.

* Prefer standard `retry.try` to custom retry implementation.

* Remove unneeded symbol.

* Remove unnecessary type annotation.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

x-pack/test/functional/apps/uptime/overview.ts

@@ -50,13 +50,11 @@ export default ({ getPageObjects }: FtrProviderContext) => {
       ]);
     });
 
-    // flakey see https://github.com/elastic/kibana/issues/54527
-    it.skip('pagination is cleared when filter criteria changes', async () => {
+    it('pagination is cleared when filter criteria changes', async () => {
       await pageObjects.uptime.goToUptimePageAndSetDateRange(DEFAULT_DATE_START, DEFAULT_DATE_END);
       await pageObjects.uptime.changePage('next');
       // there should now be pagination data in the URL
-      const contains = await pageObjects.uptime.pageUrlContains('pagination');
-      expect(contains).to.be(true);
+      await pageObjects.uptime.pageUrlContains('pagination');
       await pageObjects.uptime.pageHasExpectedIds([
         '0010-down',
         '0011-up',
@@ -71,8 +69,7 @@ export default ({ getPageObjects }: FtrProviderContext) => {
       ]);
       await pageObjects.uptime.setStatusFilter('up');
       // ensure that pagination is removed from the URL
-      const doesNotContain = await pageObjects.uptime.pageUrlContains('pagination');
-      expect(doesNotContain).to.be(false);
+      await pageObjects.uptime.pageUrlContains('pagination', false);
       await pageObjects.uptime.pageHasExpectedIds([
         '0000-intermittent',
         '0001-up',

x-pack/test/functional/page_objects/uptime_page.ts

@@ -4,11 +4,13 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
+import expect from '@kbn/expect';
 import { FtrProviderContext } from '../ftr_provider_context';
 
 export function UptimePageProvider({ getPageObjects, getService }: FtrProviderContext) {
   const pageObjects = getPageObjects(['common', 'timePicker']);
   const uptimeService = getService('uptime');
+  const retry = getService('retry');
 
   return new (class UptimePage {
     public async goToUptimePageAndSetDateRange(
@@ -51,8 +53,10 @@ export function UptimePageProvider({ getPageObjects, getService }: FtrProviderCo
       await Promise.all(monitorIdsToCheck.map(id => uptimeService.monitorPageLinkExists(id)));
     }
 
-    public async pageUrlContains(value: string) {
-      return await uptimeService.urlContains(value);
+    public async pageUrlContains(value: string, expected: boolean = true) {
+      retry.try(async () => {
+        expect(await uptimeService.urlContains(value)).to.eql(expected);
+      });
     }
 
     public async changePage(direction: 'next' | 'prev') {