Merge branch 'master' into dev/ui-actions-improve-context-2

.ci/pipeline-library/src/test/prChanges.groovy

@@ -97,4 +97,17 @@ class PrChangesTest extends KibanaBasePipelineTest {
 
     assertFalse(prChanges.areChangesSkippable())
   }
+
+  @Test
+  void 'areChangesSkippable() with plugin readme changes'() {
+    props([
+      githubPrs: [
+        getChanges: { [
+          [filename: 'src/plugins/foo/README.asciidoc'],
+        ] },
+      ],
+    ])
+
+    assertFalse(prChanges.areChangesSkippable())
+  }
 }

.eslintrc.js

@@ -132,12 +132,6 @@ module.exports = {
         'react-hooks/rules-of-hooks': 'off',
       },
     },
-    {
-      files: ['x-pack/plugins/lens/**/*.{js,mjs,ts,tsx}'],
-      rules: {
-        'react-hooks/exhaustive-deps': 'off',
-      },
-    },
     {
       files: ['x-pack/plugins/ml/**/*.{js,mjs,ts,tsx}'],
       rules: {

.github/CODEOWNERS

@@ -7,7 +7,6 @@
 /x-pack/plugins/discover_enhanced/ @elastic/kibana-app
 /x-pack/plugins/lens/ @elastic/kibana-app
 /x-pack/plugins/graph/ @elastic/kibana-app
-/src/legacy/core_plugins/kibana/public/local_application_service/ @elastic/kibana-app
 /src/plugins/dashboard/ @elastic/kibana-app
 /src/plugins/discover/ @elastic/kibana-app
 /src/plugins/input_control_vis/ @elastic/kibana-app

docs/developer/architecture/code-exploration.asciidoc

@@ -58,9 +58,9 @@ The Charts plugin is a way to create easier integration of shared colors, themes
 WARNING: Missing README.
 
 
-- {kib-repo}blob/{branch}/src/plugins/dashboard[dashboard]
+- {kib-repo}blob/{branch}/src/plugins/dashboard/README.md[dashboard]
 
-WARNING: Missing README.
+Contains the dashboard application.
 
 
 - {kib-repo}blob/{branch}/src/plugins/data/README.md[data]
@@ -76,9 +76,9 @@ Routing will be handled by the id of the dev tool - your dev tool will be mounte
 This API doesn't support angular, for registering angular dev tools, bootstrap a local module on mount into the given HTML element.
 
 
-- {kib-repo}blob/{branch}/src/plugins/discover[discover]
+- {kib-repo}blob/{branch}/src/plugins/discover/README.md[discover]
 
-WARNING: Missing README.
+Contains the Discover application and the saved search embeddable.
 
 
 - {kib-repo}blob/{branch}/src/plugins/embeddable/README.md[embeddable]
@@ -109,9 +109,9 @@ Moves the legacy ui/registry/feature_catalogue module for registering "features"
 WARNING: Missing README.
 
 
-- {kib-repo}blob/{branch}/src/plugins/input_control_vis[inputControlVis]
+- {kib-repo}blob/{branch}/src/plugins/input_control_vis/README.md[inputControlVis]
 
-WARNING: Missing README.
+Contains the input control visualization allowing to place custom filter controls on a dashboard.
 
 
 - {kib-repo}blob/{branch}/src/plugins/inspector/README.md[inspector]
@@ -206,9 +206,10 @@ This plugin adds the Advanced Settings section for the Usage Data collection (ak
 WARNING: Missing README.
 
 
-- {kib-repo}blob/{branch}/src/plugins/timelion[timelion]
+- {kib-repo}blob/{branch}/src/plugins/timelion/README.md[timelion]
 
-WARNING: Missing README.
+Contains the deprecated timelion application. For the timelion visualization,
+which also contains the timelion APIs and backend, look at the vis_type_timelion plugin.
 
 
 - {kib-repo}blob/{branch}/src/plugins/ui_actions/README.md[uiActions]
@@ -222,59 +223,63 @@ Usage Collection allows collecting usage data for other services to consume (tel
 To integrate with the telemetry services for usage collection of your feature, there are 2 steps:
 
 
-- {kib-repo}blob/{branch}/src/plugins/vis_type_markdown[visTypeMarkdown]
+- {kib-repo}blob/{branch}/src/plugins/vis_type_markdown/README.md[visTypeMarkdown]
 
-WARNING: Missing README.
+The markdown visualization that can be used to place text panels on dashboards.
 
 
-- {kib-repo}blob/{branch}/src/plugins/vis_type_metric[visTypeMetric]
+- {kib-repo}blob/{branch}/src/plugins/vis_type_metric/README.md[visTypeMetric]
 
-WARNING: Missing README.
+Contains the metric visualization.
 
 
-- {kib-repo}blob/{branch}/src/plugins/vis_type_table[visTypeTable]
+- {kib-repo}blob/{branch}/src/plugins/vis_type_table/README.md[visTypeTable]
 
-WARNING: Missing README.
+Contains the data table visualization, that allows presenting data in a simple table format.
 
 
-- {kib-repo}blob/{branch}/src/plugins/vis_type_tagcloud[visTypeTagcloud]
+- {kib-repo}blob/{branch}/src/plugins/vis_type_tagcloud/README.md[visTypeTagcloud]
 
-WARNING: Missing README.
+Contains the tagcloud visualization.
 
 
 - {kib-repo}blob/{branch}/src/plugins/vis_type_timelion/README.md[visTypeTimelion]
 
-If your grammar was changed in public/chain.peg you need to re-generate the static parser. You could use a grunt task:
+Contains the timelion visualization and the timelion backend.
 
 
-- {kib-repo}blob/{branch}/src/plugins/vis_type_timeseries[visTypeTimeseries]
+- {kib-repo}blob/{branch}/src/plugins/vis_type_timeseries/README.md[visTypeTimeseries]
 
-WARNING: Missing README.
+Contains everything around TSVB (the editor, visualizatin implementations and backends).
 
 
-- {kib-repo}blob/{branch}/src/plugins/vis_type_vega[visTypeVega]
+- {kib-repo}blob/{branch}/src/plugins/vis_type_vega/README.md[visTypeVega]
 
-WARNING: Missing README.
+Contains the Vega visualization.
 
 
-- {kib-repo}blob/{branch}/src/plugins/vis_type_vislib[visTypeVislib]
+- {kib-repo}blob/{branch}/src/plugins/vis_type_vislib/README.md[visTypeVislib]
 
-WARNING: Missing README.
+Contains the vislib visualizations. These are the classical area/line/bar, pie, gauge/goal and
+heatmap charts.
 
 
-- {kib-repo}blob/{branch}/src/plugins/vis_type_xy[visTypeXy]
+- {kib-repo}blob/{branch}/src/plugins/vis_type_xy/README.md[visTypeXy]
 
-WARNING: Missing README.
+Contains the new xy-axis chart using the elastic-charts library, which will eventually
+replace the vislib xy-axis (bar, area, line) charts.
 
 
-- {kib-repo}blob/{branch}/src/plugins/visualizations[visualizations]
+- {kib-repo}blob/{branch}/src/plugins/visualizations/README.md[visualizations]
 
-WARNING: Missing README.
+Contains most of the visualization infrastructure, e.g. the visualization type registry or the
+visualization embeddable.
 
 
-- {kib-repo}blob/{branch}/src/plugins/visualize[visualize]
+- {kib-repo}blob/{branch}/src/plugins/visualize/README.md[visualize]
 
-WARNING: Missing README.
+Contains the visualize application which includes the listing page and the app frame,
+which will load the visualization's editor.
 
 
 [discrete]
@@ -345,19 +350,22 @@ You can run a local cluster and simulate a remote cluster within a single Kibana
 
 - {kib-repo}blob/{branch}/x-pack/plugins/dashboard_enhanced/README.md[dashboardEnhanced]
 
-- {kib-repo}blob/{branch}/x-pack/plugins/dashboard_mode[dashboardMode]
+Contains the enhancements to the OSS dashboard app.
 
-WARNING: Missing README.
+
+- {kib-repo}blob/{branch}/x-pack/plugins/dashboard_mode/README.md[dashboardMode]
+
+The deprecated dashboard only mode.
 
 
 - {kib-repo}blob/{branch}/x-pack/plugins/data_enhanced[dataEnhanced]
 
 WARNING: Missing README.
 
 
-- {kib-repo}blob/{branch}/x-pack/plugins/discover_enhanced[discoverEnhanced]
+- {kib-repo}blob/{branch}/x-pack/plugins/discover_enhanced/README.md[discoverEnhanced]
 
-WARNING: Missing README.
+Contains the enhancements to the OSS discover app.
 
 
 - {kib-repo}blob/{branch}/x-pack/plugins/embeddable_enhanced[embeddableEnhanced]

docs/development/plugins/kibana_utils/public/state_sync/kibana-plugin-plugins-kibana_utils-public-state_sync.isyncstateref.md

@@ -8,7 +8,7 @@
 <b>Signature:</b>
 
 ```typescript
-export interface ISyncStateRef<stateStorage extends IStateStorage = IStateStorage> 
+export interface ISyncStateRef<StateStorage extends IStateStorage = IStateStorage> 
 ```
 
 ## Properties

docs/user/monitoring/index.asciidoc

@@ -2,6 +2,7 @@ include::xpack-monitoring.asciidoc[]
 include::beats-details.asciidoc[leveloffset=+1]
 include::cluster-alerts.asciidoc[leveloffset=+1]
 include::elasticsearch-details.asciidoc[leveloffset=+1]
+include::kibana-alerts.asciidoc[leveloffset=+1]
 include::kibana-details.asciidoc[leveloffset=+1]
 include::logstash-details.asciidoc[leveloffset=+1]
 include::monitoring-troubleshooting.asciidoc[leveloffset=+1]

docs/user/monitoring/kibana-alerts.asciidoc

@@ -0,0 +1,36 @@
+[role="xpack"]
+[[kibana-alerts]]
+= {kib} Alerts
+
+The {stack} {monitor-features} provide
+<<alerting-getting-started,{kib} alerts>> out-of-the box to notify you of
+potential issues in the {stack}. These alerts are preconfigured based on the
+best practices recommended by Elastic. However, you can tailor them to meet your 
+specific needs.
+
+When you open *{stack-monitor-app}*, the preconfigured {kib} alerts are
+created automatically. If you collect monitoring data from multiple clusters,
+these alerts can search, detect, and notify on various conditions across the
+clusters. The alerts are visible alongside your existing {watcher} cluster
+alerts. You can view details about the alerts that are active and view health
+and performance data for {es}, {ls}, and Beats in real time, as well as
+analyze past performance. You can also modify active alerts.
+
+[role="screenshot"]
+image::user/monitoring/images/monitoring-kibana-alerts.png["Kibana alerts in the Stack Monitoring app"]
+
+To review and modify all the available alerts, use
+<<managing-alerts-and-actions,*{alerts-ui}*>> in *{stack-manage-app}*.
+
+[discrete]
+[[kibana-alerts-cpu-threshold]]
+== CPU threshold
+
+This alert is triggered when a node runs a consistently high CPU load. By
+default, the trigger condition is set at 85% or more averaged over the last 5
+minutes. The alert is grouped across all the nodes of the cluster by running
+checks on a schedule time of 1 minute with a re-notify internal of 1 day. 
+
+NOTE: Some action types are subscription features, while others are free.
+For a comparison of the Elastic subscription levels, see the alerting section of
+the {subscriptions}[Subscriptions page].

examples/alerting_example/public/components/create_alert.tsx

@@ -30,6 +30,7 @@ import { ALERTING_EXAMPLE_APP_ID } from '../../common/constants';
 
 export const CreateAlert = ({
   http,
+  // eslint-disable-next-line @typescript-eslint/naming-convention
   triggers_actions_ui,
   charts,
   uiSettings,

examples/alerting_example/public/plugin.tsx

@@ -46,6 +46,7 @@ export interface AlertingExamplePublicStartDeps {
 export class AlertingExamplePlugin implements Plugin<Setup, Start, AlertingExamplePublicSetupDeps> {
   public setup(
     core: CoreSetup<AlertingExamplePublicStartDeps, Start>,
+    // eslint-disable-next-line @typescript-eslint/naming-convention
     { alerts, triggers_actions_ui, developerExamples }: AlertingExamplePublicSetupDeps
   ) {
     core.application.register({

kibana.d.ts

@@ -35,7 +35,6 @@ import * as LegacyKibanaServer from './src/legacy/server/kbn_server';
 /**
  *  Re-export legacy types under a namespace.
  */
-// eslint-disable-next-line @typescript-eslint/no-namespace
 export namespace Legacy {
   export type KibanaConfig = LegacyKibanaServer.KibanaConfig;
   export type Request = LegacyKibanaServer.Request;

package.json

@@ -400,8 +400,8 @@
     "@types/vinyl": "^2.0.4",
     "@types/vinyl-fs": "^2.4.11",
     "@types/zen-observable": "^0.8.0",
-    "@typescript-eslint/eslint-plugin": "^2.34.0",
-    "@typescript-eslint/parser": "^2.34.0",
+    "@typescript-eslint/eslint-plugin": "^3.7.1",
+    "@typescript-eslint/parser": "^3.7.1",
     "angular-mocks": "^1.7.9",
     "archiver": "^3.1.1",
     "axe-core": "^3.4.1",
@@ -425,6 +425,7 @@
     "eslint-plugin-babel": "^5.3.0",
     "eslint-plugin-ban": "^1.4.0",
     "eslint-plugin-cypress": "^2.8.1",
+    "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-import": "^2.19.1",
     "eslint-plugin-jest": "^23.10.0",
     "eslint-plugin-jsx-a11y": "^6.2.3",

packages/eslint-config-kibana/package.json

@@ -11,17 +11,18 @@
   "author": "Spencer Alger <email@spalger.com>",
   "license": "Apache-2.0",
   "bugs": {
-    "url": "https://github.com/elastic/eslint-config-kibana/issues"
+    "url": "https://github.com/elastic/kibana/tree/master/packages/eslint-config-kibana"
   },
-  "homepage": "https://github.com/elastic/eslint-config-kibana#readme",
+  "homepage": "https://github.com/elastic/kibana/tree/master/packages/eslint-config-kibana",
   "peerDependencies": {
-    "@typescript-eslint/eslint-plugin": "^2.34.0",
-    "@typescript-eslint/parser": "^2.34.0",
+    "@typescript-eslint/eslint-plugin": "^3.7.1",
+    "@typescript-eslint/parser": "^3.7.1",
     "babel-eslint": "^10.0.3",
     "eslint": "^6.8.0",
     "eslint-plugin-babel": "^5.3.0",
     "eslint-plugin-ban": "^1.4.0",
     "eslint-plugin-jsx-a11y": "^6.2.3",
+    "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-import": "^2.19.1",
     "eslint-plugin-jest": "^23.10.0",
     "eslint-plugin-mocha": "^6.2.2",