Add comments and fix test since removing the unused APIs

x-pack/plugins/security/public/nav_control/nav_control_service.tsx

@@ -31,12 +31,12 @@ interface StartDeps {
 
 export interface SecurityNavControlServiceStart {
   /**
-   * Returns an Observable of the array of user menu links registered by other plugins
+   * Returns an Observable of the array of user menu links (the links that show up under the users Avatar in the UI) registered by other plugins
    */
   getUserMenuLinks$: () => Observable<UserMenuLink[]>;
 
   /**
-   * Registers the provided user menu links to be displayed in the user menu in the global nav
+   * Registers the provided user menu links to be displayed in the user menu (the links that show up under the users Avatar in the UI).
    */
   addUserMenuLinks: (newUserMenuLink: UserMenuLink[]) => void;
 }

x-pack/plugins/security/public/plugin.test.tsx

@@ -43,7 +43,6 @@ describe('Security Plugin', () => {
           }
         )
       ).toEqual({
-        __legacyCompat: { logoutUrl: '/some-base-path/logout', tenant: '/some-base-path' },
         authc: { getCurrentUser: expect.any(Function), areAPIKeysEnabled: expect.any(Function) },
         license: {
           isLicenseAvailable: expect.any(Function),
@@ -52,7 +51,6 @@ describe('Security Plugin', () => {
           getFeatures: expect.any(Function),
           features$: expect.any(Observable),
         },
-        sessionTimeout: expect.any(SessionTimeout),
       });
     });
 

x-pack/plugins/security/public/plugin.tsx

@@ -176,6 +176,9 @@ export interface SecurityPluginSetup {
 }
 
 export interface SecurityPluginStart {
+  /**
+   * Exposes the ability to add custom links to the dropdown menu in the top right, where the users Avatar is.
+   */
   navControlService: SecurityNavControlServiceStart;
   /**
    * Exposes authentication information about the currently logged in user.