Skip to content

Commit

Permalink
really listening to Nathan this time
Browse files Browse the repository at this point in the history
  • Loading branch information
alexfrancoeur committed Aug 28, 2018
1 parent 41ce8f6 commit 2fc50b0
Showing 1 changed file with 3 additions and 13 deletions.
16 changes: 3 additions & 13 deletions test/functional/apps/home/_sample_data.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,17 +54,12 @@ export default function ({ getService, getPageObjects }) {

it('should install logs sample data set', async ()=> {
await PageObjects.home.addSampleDataSet('logs');
await retry.try(async () => {
const successToastExists = await PageObjects.home.doesSampleDataSetSuccessfulInstallToastExist();
expect(successToastExists).to.be(true);
});

const isInstalled = await PageObjects.home.isSampleDataSetInstalled('logs');
expect(isInstalled).to.be(true);
});

describe('dashboard', () => {
after(async () => {
afterEach(async () => {
await PageObjects.common.navigateToUrl('home', 'tutorial_directory/sampleData');
await PageObjects.header.waitUntilLoadingHasFinished();
});
Expand Down Expand Up @@ -107,7 +102,7 @@ export default function ({ getService, getPageObjects }) {
expect(tsvb).to.be(true);
});

it.skip('should launch sample logs data set dashboard', async ()=> {
it('should launch sample logs data set dashboard', async ()=> {
await PageObjects.home.launchSampleDataSet('logs');
await PageObjects.header.waitUntilLoadingHasFinished();
const today = new Date();
Expand All @@ -130,12 +125,7 @@ export default function ({ getService, getPageObjects }) {
});

it('should uninstall logs sample data set', async ()=> {
await PageObjects.home.removeSampleDataSet('logs');
await retry.try(async () => {
const successToastExists = await PageObjects.home.doesSampleDataSetSuccessfulUninstallToastExist();
expect(successToastExists).to.be(true);
});

await PageObjects.home.removeSampleDataSet('flights');

This comment has been minimized.

Copy link
@nreese

nreese Aug 28, 2018

Contributor

I think this should be logs instead of flights

This comment has been minimized.

Copy link
@alexfrancoeur

alexfrancoeur Aug 28, 2018

😦 fixed

const isInstalled = await PageObjects.home.isSampleDataSetInstalled('logs');
expect(isInstalled).to.be(false);
});
Expand Down

0 comments on commit 2fc50b0

Please sign in to comment.