Fix tests

elastic · Jan 24, 2017 · 33b4f24 · 33b4f24
1 parent fbdaa84
commit 33b4f24
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/src/core_plugins/kibana/public/dashboard/listing/dashboard_listing.html b/src/core_plugins/kibana/public/dashboard/listing/dashboard_listing.html
@@ -25,6 +25,7 @@
             type="text"
             placeholder="Search..."
             aria-label="Filter"
+            data-test-subj="searchFilter"
             ng-model="listingController.filter"
           >
         </div>

diff --git a/test/functional/apps/dashboard/_dashboard.js b/test/functional/apps/dashboard/_dashboard.js
@@ -83,7 +83,8 @@ bdd.describe('dashboard tab', function describeIndexTests() {
       const dashboardName = 'Dashboard Test 1';
       // TODO: save time on the dashboard and test it
       return PageObjects.dashboard.saveDashboard(dashboardName)
-      // click New Dashboard just to clear the one we just created
+        .then(() => PageObjects.dashboard.gotoDashboardLandingPage())
+        // click New Dashboard just to clear the one we just created
         .then(function () {
           return PageObjects.common.try(function () {
             PageObjects.common.debug('saved Dashboard, now click New Dashboard');

diff --git a/test/support/page_objects/dashboard_page.js b/test/support/page_objects/dashboard_page.js
@@ -131,10 +131,9 @@ export default class DashboardPage {
     return this.gotoDashboardLandingPage()
     .then(function filterDashboard() {
       PageObjects.common.debug('Load Saved Dashboard button clicked');
-      return self.remote
-      .findByCssSelector('input[name="filter"]')
-      .click()
-      .type(dashName.replace('-',' '));
+      return PageObjects.common.findTestSubject('searchFilter')
+        .click()
+        .type(dashName.replace('-',' '));
     })
     .then(() => {
       return PageObjects.header.isGlobalLoadingIndicatorHidden();