use object options for createHref

elastic · Apr 10, 2020 · 353277d · 353277d
1 parent 052cdea
commit 353277d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/core/public/application/scoped_history.test.ts b/src/core/public/application/scoped_history.test.ts
@@ -289,10 +289,10 @@ describe('ScopedHistory', () => {
       const gh = createMemoryHistory();
       gh.push('/app/wow');
       const h = new ScopedHistory(gh, '/app/wow');
-      expect(h.createHref({ pathname: '' }, false)).toEqual(`/`);
-      expect(h.createHref({ pathname: '/new-page', search: '?alpha=true' }, false)).toEqual(
-        `/new-page?alpha=true`
-      );
+      expect(h.createHref({ pathname: '' }, { prependBasePath: false })).toEqual(`/`);
+      expect(
+        h.createHref({ pathname: '/new-page', search: '?alpha=true' }, { prependBasePath: false })
+      ).toEqual(`/new-page?alpha=true`);
     });
   });
 

diff --git a/src/core/public/application/scoped_history.ts b/src/core/public/application/scoped_history.ts
@@ -226,7 +226,7 @@ export class ScopedHistory<HistoryLocationState = unknown>
    */
   public createHref = (
     location: LocationDescriptorObject<HistoryLocationState>,
-    prependBasePath: boolean = true
+    { prependBasePath = true }: { prependBasePath?: boolean } = {}
   ): Href => {
     this.verifyActive();
     if (prependBasePath) {