Tweaks needed for integrating with the functional test runner (#11469)

* [git] ignore the entire root optimize directory

* [ftr] fix readConfigFile export

* [ftr/config] set default hostname and protocols for urls

* [chrome] make top-level chrome a test-subject

* [ftr/CommonPage] only auto-login when not navigating to the login page

.gitignore

@@ -5,9 +5,7 @@
 .node_binaries
 node_modules
 trash
-/optimize/bundles
-/optimize/testdev
-/optimize/testUiServer
+/optimize
 target
 /build
 .jruby

src/functional_test_runner/lib/config/index.js

@@ -1 +1 @@
-export { readConfigFile } from './create_config';
+export { readConfigFile } from './read_config_file';

src/functional_test_runner/lib/config/create_config.js → src/functional_test_runner/lib/config/read_config_file.js

@@ -2,7 +2,7 @@ import { defaultsDeep } from 'lodash';
 
 import { Config } from './config';
 
-export async function readConfigFile(log, configFile, settingOverrides) {
+export async function readConfigFile(log, configFile, settingOverrides = {}) {
   log.debug('Loading config file from %j', configFile);
 
   const configModule = require(configFile);

src/functional_test_runner/lib/config/schema.js

@@ -8,8 +8,8 @@ const ID_PATTERN = /^[a-zA-Z0-9_]+$/;
 const INSPECTING = process.execArgv.includes('--inspect');
 
 const urlPartsSchema = () => Joi.object().keys({
-  protocol: Joi.string().valid('http', 'https'),
-  hostname: Joi.string().hostname(),
+  protocol: Joi.string().valid('http', 'https').default('http'),
+  hostname: Joi.string().hostname().default('localhost'),
   port: Joi.number(),
   auth: Joi.string().regex(/^[^:]+:.+$/, 'username and password seperated by a colon'),
   username: Joi.string(),

src/ui/public/chrome/directives/kbn_chrome.html

@@ -1,4 +1,4 @@
-<div class="content" chrome-context >
+<div class="content" chrome-context data-test-subj="kibanaChrome">
   <global-nav
     chrome="chrome"
     is-visible="chrome.getVisible()"

test/functional/page_objects/common_page.js

@@ -79,8 +79,9 @@ export function CommonPageProvider({ getService, getPageObjects }) {
             return remote.getCurrentUrl();
           })
           .then(function (currentUrl) {
-            const loginPage = new RegExp('login').test(currentUrl);
-            if (loginPage) {
+            const loginPage = currentUrl.includes('/login');
+            const wantedLoginPage = appUrl.includes('/login') || appUrl.includes('/logout');
+            if (loginPage && !wantedLoginPage) {
               log.debug('Found loginPage username = '
                 + config.get('servers.kibana.username'));
               return PageObjects.shield.login(config.get('servers.kibana.username'),