Address code review comments

- rename bread_crumb_url => bread_crumb_urls - fix reporting link in dash (separate PR) - Use NoItems instead of PromptForItems when searching - Style fixes
elastic · Jan 24, 2017 · 41f6495 · 41f6495
1 parent a1b84ca
commit 41f6495
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 7 deletions.
diff --git a/src/core_plugins/kibana/public/dashboard/listing/dashboard_listing.html b/src/core_plugins/kibana/public/dashboard/listing/dashboard_listing.html
@@ -60,16 +60,25 @@
       </div>
     </div>
 
+    <!-- NoResults -->
+    <div ng-if="!listingController.items.length && listingController.filter" class="kuiPanel kuiPanel--centered">
+      <div class="kuiNoItems">
+        No dashboards matched your search.
+      </div>
+    </div>
+
     <!-- PromptForItems -->
-    <div class="kuiPanel kuiPanel--centered" ng-if="!listingController.items.length">
+    <div class="kuiPanel kuiPanel--centered" ng-if="!listingController.items.length && !listingController.filter">
       <div class="kuiPromptForItems">
         <div class="kuiPromptForItems__message">
           Looks like you don&rsquo;t have any dashboards. Let&rsquo;s add some!
         </div>
 
         <div class="kuiPromptForItems__actions">
-          <a class="kuiButton kuiButton--primary kuiButton--iconText"
-                  href="#/dashboard/create">
+          <a
+            class="kuiButton kuiButton--primary kuiButton--iconText"
+            href="#/dashboard/create"
+          >
             <span class="kuiButton__icon kuiIcon fa-plus"></span>
             Add a dashboard
           </a>
@@ -92,10 +101,10 @@
 
         <th class="kuiTableHeaderCell" ng-click="listingController.sortHits()">
           Name
-          <i
+          <span
             class="fa"
             ng-class="listingController.isAscending ? 'fa-caret-up' : 'fa-caret-down'">
-          </i>
+          </span>
         </th>
       </tr>
       </thead>

diff --git a/src/ui/public/kbn_top_nav/__tests__/bread_crumb_urls.js b/src/ui/public/kbn_top_nav/__tests__/bread_crumb_urls.js
@@ -1,6 +1,6 @@
 import expect from 'expect.js';
 
-import { getBreadCrumbUrls } from '../bread_crumbs/bread_crumb_url';
+import { getBreadCrumbUrls } from '../bread_crumbs/bread_crumb_urls';
 
 describe('getBreadCrumbUrls', function () {
 

diff --git a/...n_top_nav/bread_crumbs/bread_crumb_url.js → ..._top_nav/bread_crumbs/bread_crumb_urls.js b/...n_top_nav/bread_crumbs/bread_crumb_url.js → ..._top_nav/bread_crumbs/bread_crumb_urls.js
diff --git a/src/ui/public/kbn_top_nav/bread_crumbs/bread_crumbs.js b/src/ui/public/kbn_top_nav/bread_crumbs/bread_crumbs.js
@@ -1,7 +1,7 @@
 import _ from 'lodash';
 import chrome from 'ui/chrome/chrome';
 import breadCrumbsTemplate from './bread_crumbs.html';
-import { getBreadCrumbUrls } from './bread_crumb_url';
+import { getBreadCrumbUrls } from './bread_crumb_urls';
 import uiModules from 'ui/modules';
 const module = uiModules.get('kibana');