fix PR comments

elastic · Apr 13, 2020 · 4304089 · 4304089
1 parent 82e3788
commit 4304089
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 30 deletions.
diff --git a/...dex_patterns/edit_index_pattern/source_filters_table/components/add_filter/add_filter.tsx b/...dex_patterns/edit_index_pattern/source_filters_table/components/add_filter/add_filter.tsx
@@ -18,7 +18,6 @@
  */
 
 import React, { useState, useCallback } from 'react';
-import PropTypes from 'prop-types';
 
 import { i18n } from '@kbn/i18n';
 import { FormattedMessage } from '@kbn/i18n/react';
@@ -62,7 +61,3 @@ export const AddFilter = ({ onAddFilter }: AddFilterProps) => {
     </EuiFlexGroup>
   );
 };
-
-AddFilter.propTypes = {
-  onAddFilter: PropTypes.func.isRequired,
-};
diff --git a/...ections/index_patterns/edit_index_pattern/source_filters_table/components/table/table.tsx b/...ections/index_patterns/edit_index_pattern/source_filters_table/components/table/table.tsx
@@ -18,7 +18,6 @@
  */
 
 import React, { Component } from 'react';
-import PropTypes from 'prop-types';
 
 import {
   keyCodes,
@@ -84,15 +83,6 @@ export interface TableState {
 }
 
 export class Table extends Component<TableProps, TableState> {
-  static propTypes = {
-    indexPattern: PropTypes.object.isRequired,
-    items: PropTypes.array.isRequired,
-    deleteFilter: PropTypes.func.isRequired,
-    fieldWildcardMatcher: PropTypes.func.isRequired,
-    saveFilter: PropTypes.func.isRequired,
-    isSaving: PropTypes.bool.isRequired,
-  };
-
   constructor(props: TableProps) {
     super(props);
     this.state = {
@@ -155,16 +145,13 @@ export class Table extends Component<TableProps, TableState> {
         dataType: 'string',
         sortable: true,
         render: (value, filter) => {
+          const wildcardMatcher = fieldWildcardMatcher([
+            this.state.editingFilterId === filter.clientId ? this.state.editingFilterValue : value,
+          ]);
           const matches = indexPattern
             .getNonScriptedFields()
             .map((currentFilter: any) => currentFilter.name)
-            .filter(
-              fieldWildcardMatcher([
-                this.state.editingFilterId === filter.clientId
-                  ? this.state.editingFilterValue
-                  : value,
-              ])
-            )
+            .filter(wildcardMatcher)
             .sort();
 
           if (matches.length) {

diff --git a/.../sections/index_patterns/edit_index_pattern/source_filters_table/source_filters_table.tsx b/.../sections/index_patterns/edit_index_pattern/source_filters_table/source_filters_table.tsx
@@ -18,7 +18,6 @@
  */
 
 import React, { Component } from 'react';
-import PropTypes from 'prop-types';
 import { createSelector } from 'reselect';
 
 import { EuiSpacer } from '@elastic/eui';
@@ -44,13 +43,6 @@ export class SourceFiltersTable extends Component<
   SourceFiltersTableProps,
   SourceFiltersTableState
 > {
-  static propTypes = {
-    indexPattern: PropTypes.object.isRequired,
-    filterFilter: PropTypes.string,
-    fieldWildcardMatcher: PropTypes.func.isRequired,
-    onAddOrRemoveFilter: PropTypes.func,
-  };
-
   // Source filters do not have any unique ids, only the value is stored.
   // To ensure we can create a consistent and expected UX when managing
   // source filters, we are assigning a unique id to each filter on the