issue 57946 fix flaky endpoint policy list test

elastic · Feb 24, 2020 · 43e9f34 · 43e9f34
1 parent 345bf1f
commit 43e9f34
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/x-pack/test/functional/apps/endpoint/policy_list.ts b/x-pack/test/functional/apps/endpoint/policy_list.ts
@@ -11,10 +11,11 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
   const testSubjects = getService('testSubjects');
 
   // FLAKY: https://github.com/elastic/kibana/issues/57946
-  describe.skip('Endpoint Policy List', function() {
+  describe('Endpoint Policy List', function() {
     this.tags(['ciGroup7']);
     before(async () => {
       await pageObjects.common.navigateToUrlWithBrowserHistory('endpoint', '/policy');
+      await pageObjects.endpoint.waitForTableToHaveData('policyTable');
     });
 
     it('loads the Policy List Page', async () => {
@@ -26,7 +27,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
     });
     it('shows policy count total', async () => {
       const policyTotal = await testSubjects.getVisibleText('policyTotalCount');
-      expect(policyTotal).to.equal('0 Policies');
+      expect(policyTotal).to.equal('100 Policies');
     });
     it('includes policy list table', async () => {
       await testSubjects.existOrFail('policyTable');

diff --git a/x-pack/test/functional/page_objects/endpoint_page.ts b/x-pack/test/functional/page_objects/endpoint_page.ts
@@ -9,6 +9,7 @@ import { FtrProviderContext } from '../ftr_provider_context';
 
 export function EndpointPageProvider({ getService }: FtrProviderContext) {
   const testSubjects = getService('testSubjects');
+  const retry = getService('retry');
 
   return {
     /**
@@ -58,5 +59,13 @@ export function EndpointPageProvider({ getService }: FtrProviderContext) {
             )
         );
     },
+
+    async waitForTableToHaveData(dataTestSubj: string) {
+      await retry.waitForWithTimeout('table to have data', 2000, async () => {
+        const tableData = await this.getEndpointAppTableData(dataTestSubj);
+        if (tableData[1][0] === 'No items found') return false;
+        return true;
+      });
+    },
   };
 }