Clean up component + remove .only

elastic · Oct 17, 2023 · 484495e · 484495e
1 parent d88e1ea
commit 484495e
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 32 deletions.
diff --git a/src/plugins/dashboard/public/dashboard_listing/dashboard_unsaved_listing.tsx b/src/plugins/dashboard/public/dashboard_listing/dashboard_unsaved_listing.tsx
@@ -179,36 +179,33 @@ export const DashboardUnsavedListing = ({
     };
   }, [refreshUnsavedDashboards, dashboardBackup, unsavedDashboardIds, findDashboards]);
 
-  return (
-    unsavedDashboardIds.length > 0 && (
-      <>
-        <EuiCallOut
-          heading="h3"
-          data-test-subj="unsavedDashboardsCallout"
-          title={dashboardUnsavedListingStrings.getUnsavedChangesTitle(
-            unsavedDashboardIds.length > 1
-          )}
-        >
-          {unsavedDashboardIds.map((dashboardId: string) => {
-            const title: string | undefined =
-              dashboardId === DASHBOARD_PANELS_UNSAVED_ID
-                ? getNewDashboardTitle()
-                : items[dashboardId]?.title;
-            const redirectId =
-              dashboardId === DASHBOARD_PANELS_UNSAVED_ID ? undefined : dashboardId;
-            return (
-              <DashboardUnsavedItem
-                key={dashboardId}
-                id={dashboardId}
-                title={title}
-                onOpenClick={() => onOpen(redirectId)}
-                onDiscardClick={() => onDiscard(redirectId)}
-              />
-            );
-          })}
-        </EuiCallOut>
-        <EuiSpacer size="m" />
-      </>
-    )
+  return unsavedDashboardIds.length === 0 ? null : (
+    <>
+      <EuiCallOut
+        heading="h3"
+        data-test-subj="unsavedDashboardsCallout"
+        title={dashboardUnsavedListingStrings.getUnsavedChangesTitle(
+          unsavedDashboardIds.length > 1
+        )}
+      >
+        {unsavedDashboardIds.map((dashboardId: string) => {
+          const title: string | undefined =
+            dashboardId === DASHBOARD_PANELS_UNSAVED_ID
+              ? getNewDashboardTitle()
+              : items[dashboardId]?.title;
+          const redirectId = dashboardId === DASHBOARD_PANELS_UNSAVED_ID ? undefined : dashboardId;
+          return (
+            <DashboardUnsavedItem
+              key={dashboardId}
+              id={dashboardId}
+              title={title}
+              onOpenClick={() => onOpen(redirectId)}
+              onDiscardClick={() => onDiscard(redirectId)}
+            />
+          );
+        })}
+      </EuiCallOut>
+      <EuiSpacer size="m" />
+    </>
   );
 };
diff --git a/test/functional/apps/dashboard/group1/dashboard_unsaved_state.ts b/test/functional/apps/dashboard/group1/dashboard_unsaved_state.ts
@@ -23,7 +23,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   let unsavedPanelCount = 0;
   const testQuery = 'Test Query';
 
-  describe.only('dashboard unsaved state', () => {
+  describe('dashboard unsaved state', () => {
     before(async () => {
       await kibanaServer.savedObjects.cleanStandardList();
       await kibanaServer.importExport.load(