[canvas] Reduce bundle size by combining SCSS imports

elastic · Jun 21, 2021 · 4ba7041 · 4ba7041
1 parent 7c429f7
commit 4ba7041
Show file tree

Hide file tree

Showing 8 changed files with 7 additions and 15 deletions.
diff --git a/x-pack/plugins/canvas/public/components/var_config/delete_var.tsx b/x-pack/plugins/canvas/public/components/var_config/delete_var.tsx
@@ -20,8 +20,6 @@ import { CanvasVariable } from '../../../types';
 import { ComponentStrings } from '../../../i18n';
 const { VarConfigDeleteVar: strings } = ComponentStrings;
 
-import './var_panel.scss';
-
 interface Props {
   selectedVar: CanvasVariable;
   onDelete: (v: CanvasVariable) => void;

diff --git a/x-pack/plugins/canvas/public/components/var_config/edit_var.tsx b/x-pack/plugins/canvas/public/components/var_config/edit_var.tsx
@@ -27,9 +27,6 @@ import { VarValueField } from './var_value_field';
 import { ComponentStrings } from '../../../i18n';
 const { VarConfigEditVar: strings } = ComponentStrings;
 
-import './edit_var.scss';
-import './var_panel.scss';
-
 interface Props {
   selectedVar: CanvasVariable | null;
   variables: CanvasVariable[];

diff --git a/x-pack/plugins/canvas/public/components/var_config/var_config.tsx b/x-pack/plugins/canvas/public/components/var_config/var_config.tsx
@@ -25,8 +25,6 @@ import { ComponentStrings } from '../../../i18n';
 import { EditVar } from './edit_var';
 import { DeleteVar } from './delete_var';
 
-import './var_config.scss';
-
 const { VarConfig: strings } = ComponentStrings;
 
 enum PanelMode {

diff --git a/x-pack/plugins/canvas/public/style/index.scss b/x-pack/plugins/canvas/public/style/index.scss
@@ -45,6 +45,13 @@
 @import '../components/workpad_page/workpad_page';
 @import '../components/workpad_page/workpad_interactive_page/workpad_interactive_page';
 @import '../components/workpad_page/workpad_static_page/workpad_static_page';
+@import '../components/var_config/edit_var';
+@import '../components/var_config/var_config';
+
+@import '../transitions/fade/fade';
+@import '../transitions/rotate/rotate';
+@import '../transitions/slide/slide';
+@import '../transitions/zoom/zoom';
 
 @import '../../canvas_plugin_src/renderers/filters/advanced_filter/component/advanced_filter.scss';
 @import '../../canvas_plugin_src/renderers/filters/dropdown_filter/component/dropdown_filter.scss';

diff --git a/x-pack/plugins/canvas/public/transitions/fade/index.ts b/x-pack/plugins/canvas/public/transitions/fade/index.ts
@@ -5,8 +5,6 @@
  * 2.0.
  */
 
-import './fade.scss';
-
 import { TransitionStrings } from '../../../i18n';
 
 const { fade: strings } = TransitionStrings;

diff --git a/x-pack/plugins/canvas/public/transitions/rotate/index.ts b/x-pack/plugins/canvas/public/transitions/rotate/index.ts
@@ -5,8 +5,6 @@
  * 2.0.
  */
 
-import './rotate.scss';
-
 import { TransitionStrings } from '../../../i18n';
 
 const { rotate: strings } = TransitionStrings;

diff --git a/x-pack/plugins/canvas/public/transitions/slide/index.ts b/x-pack/plugins/canvas/public/transitions/slide/index.ts
@@ -5,8 +5,6 @@
  * 2.0.
  */
 
-import './slide.scss';
-
 import { TransitionStrings } from '../../../i18n';
 
 const { slide: strings } = TransitionStrings;

diff --git a/x-pack/plugins/canvas/public/transitions/zoom/index.ts b/x-pack/plugins/canvas/public/transitions/zoom/index.ts
@@ -5,8 +5,6 @@
  * 2.0.
  */
 
-import './zoom.scss';
-
 import { TransitionStrings } from '../../../i18n';
 
 const { zoom: strings } = TransitionStrings;