revert merge mistakes and pass in all services

elastic · Apr 8, 2020 · 4c9397e · 4c9397e
1 parent 5e96a62
commit 4c9397e
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 9 deletions.
diff --git a/src/plugins/vis_default_editor/public/components/controls/order_by.tsx b/src/plugins/vis_default_editor/public/components/controls/order_by.tsx
@@ -60,13 +60,16 @@ function OrderByParamEditor({
 
   useValidation(setValidity, isValid);
   useMount(() => {
-    let respAgg = { id: DEFAULT_VALUE };
+    // setup the initial value of orderBy
+    if (!value) {
+      let respAgg = { id: DEFAULT_VALUE };
 
-    if (metricAggs) {
-      respAgg = metricAggs.filter(isCompatibleAgg)[0] || respAgg;
-    }
+      if (metricAggs) {
+        respAgg = metricAggs.filter(isCompatibleAgg)[0] || respAgg;
+      }
 
-    setValue(respAgg.id);
+      setValue(respAgg.id);
+    }
   });
 
   useFallbackMetric(setValue, termsAggFilter, metricAggs, value, DEFAULT_VALUE);

diff --git a/src/plugins/vis_default_editor/public/components/controls/radius_ratio_option.tsx b/src/plugins/vis_default_editor/public/components/controls/radius_ratio_option.tsx
@@ -44,6 +44,7 @@ function RadiusRatioOptionControl({ editorStateParams, setStateParamValue }: Agg
       />
     </>
   );
+
   useMount(() => {
     if (!editorStateParams.radiusRatio) {
       setStateParamValue(PARAM_NAME, DEFAULT_VALUE);

diff --git a/src/plugins/vis_type_timelion/public/timelion_options.tsx b/src/plugins/vis_type_timelion/public/timelion_options.tsx
@@ -19,14 +19,14 @@
 
 import React, { useCallback } from 'react';
 import { EuiPanel } from '@elastic/eui';
-import { IUiSettingsClient } from 'kibana/public';
 
 import { VisOptionsProps } from 'src/plugins/vis_default_editor/public';
 import { VisParams } from './timelion_vis_fn';
 import { TimelionInterval, TimelionExpressionInput } from './components';
 import { KibanaContextProvider } from '../../kibana_react/public';
+import { TimelionVisDependencies } from './plugin';
 
-const TimelionOptions = (uiSettings: IUiSettingsClient) => {
+const TimelionOptions = (dependencies: TimelionVisDependencies) => {
   const TimelionOptionsComponent = ({
     stateParams,
     setValue,
@@ -41,7 +41,7 @@ const TimelionOptions = (uiSettings: IUiSettingsClient) => {
     );
 
     return (
-      <KibanaContextProvider services={{ uiSettings }}>
+      <KibanaContextProvider services={dependencies}>
         <EuiPanel className="visEditorSidebar__timelionOptions" paddingSize="s">
           <TimelionInterval
             value={stateParams.interval}

diff --git a/src/plugins/vis_type_timelion/public/timelion_vis_type.tsx b/src/plugins/vis_type_timelion/public/timelion_vis_type.tsx
@@ -53,7 +53,7 @@ export function getTimelionVisDefinition(dependencies: TimelionVisDependencies)
       ),
     },
     editorConfig: {
-      optionsTemplate: TimelionOptions(dependencies.uiSettings),
+      optionsTemplate: TimelionOptions(dependencies),
       defaultSize: DefaultEditorSize.MEDIUM,
     },
     requestHandler: timelionRequestHandler,