code tweaks

elastic · Aug 2, 2019 · 5a299b3 · 5a299b3
1 parent e10af0e
commit 5a299b3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 13 deletions.
diff --git a/...onDetails/Transaction/WaterfallContainer/Waterfall/waterfall_helpers/waterfall_helpers.ts b/...onDetails/Transaction/WaterfallContainer/Waterfall/waterfall_helpers/waterfall_helpers.ts
@@ -5,15 +5,7 @@
  */
 
 import theme from '@elastic/eui/dist/eui_theme_light.json';
-import {
-  flatten,
-  groupBy,
-  indexBy,
-  isEmpty,
-  sortBy,
-  uniq,
-  zipObject
-} from 'lodash';
+import { flatten, groupBy, indexBy, sortBy, uniq, zipObject } from 'lodash';
 import { idx } from '@kbn/elastic-idx';
 import { TraceAPIResponse } from '../../../../../../../../server/lib/traces/get_trace';
 import { StringMap } from '../../../../../../../../typings/common';
@@ -226,7 +218,7 @@ export function getWaterfall(
   { root: traceRoot, trace, errorsPerTransaction }: TraceAPIResponse,
   entryTransactionId?: Transaction['transaction']['id']
 ): IWaterfall {
-  if (traceRoot === undefined || isEmpty(trace) || !entryTransactionId) {
+  if (traceRoot === undefined || !entryTransactionId) {
     return {
       services: [],
       duration: 0,

diff --git a/x-pack/legacy/plugins/apm/server/lib/traces/get_trace_root.ts b/x-pack/legacy/plugins/apm/server/lib/traces/get_trace_root.ts
@@ -5,6 +5,7 @@
  */
 
 import { SearchParams } from 'elasticsearch';
+import { idx } from '@kbn/elastic-idx';
 import {
   PROCESSOR_EVENT,
   TRACE_ID,
@@ -40,9 +41,7 @@ export async function getTraceRoot(traceId: string, setup: Setup) {
   };
 
   const resp = await client.search<Transaction>(params);
-  const root = resp.hits.hits.map(hit => hit._source)[0] as
-    | Transaction
-    | undefined;
+  const root: Transaction | undefined = idx(resp, _ => _.hits.hits[0]._source);
 
   return root;
 }