Merge remote-tracking branch 'origin/master' into tsvb-colors

.ci/Jenkinsfile_coverage

@@ -44,7 +44,7 @@ kibanaPipeline(timeoutMinutes: 180) {
           'xpack-ciGroup10': kibanaPipeline.xpackCiGroupProcess(10),
         ]),
       ])
-      workers.base(name: 'coverage-worker', label: 'tests-l', ramDisk: false, bootstrapped: false) {
+      workers.base(name: 'coverage-worker', size: 'l', ramDisk: false, bootstrapped: false) {
         kibanaPipeline.downloadCoverageArtifacts()
         kibanaPipeline.bash(
           '''

.ci/Jenkinsfile_visual_baseline

@@ -7,12 +7,12 @@ kibanaPipeline(timeoutMinutes: 120) {
   catchError {
     parallel([
       'oss-visualRegression': {
-        workers.ci(name: 'oss-visualRegression', label: 'linux && immutable', ramDisk: false) {
+        workers.ci(name: 'oss-visualRegression', size: 's', ramDisk: false) {
           kibanaPipeline.functionalTestProcess('oss-visualRegression', './test/scripts/jenkins_visual_regression.sh')(1)
         }
       },
       'xpack-visualRegression': {
-        workers.ci(name: 'xpack-visualRegression', label: 'linux && immutable', ramDisk: false) {
+        workers.ci(name: 'xpack-visualRegression', size: 's', ramDisk: false) {
           kibanaPipeline.functionalTestProcess('xpack-visualRegression', './test/scripts/jenkins_xpack_visual_regression.sh')(1)
         }
       },

.ci/es-snapshots/Jenkinsfile_build_es

@@ -25,7 +25,7 @@ def PROMOTE_WITHOUT_VERIFY = !!params.PROMOTE_WITHOUT_VERIFICATION
 timeout(time: 120, unit: 'MINUTES') {
   timestamps {
     ansiColor('xterm') {
-      node('linux && immutable') {
+      node(workers.label('s')) {
         catchErrors {
           def VERSION
           def SNAPSHOT_ID

.ci/es-snapshots/Jenkinsfile_verify_es

@@ -61,7 +61,7 @@ kibanaPipeline(timeoutMinutes: 120) {
 }
 
 def promoteSnapshot(snapshotVersion, snapshotId) {
-  node('linux && immutable') {
+  node(workers.label('s')) {
     esSnapshots.promote(snapshotVersion, snapshotId)
   }
 }

.github/CODEOWNERS

@@ -15,18 +15,20 @@
 /src/legacy/core_plugins/metrics/ @elastic/kibana-app
 /src/legacy/core_plugins/vis_type_vislib/ @elastic/kibana-app
 /src/legacy/core_plugins/vis_type_xy/ @elastic/kibana-app
-# Exclude tutorials folder for now because they are not owned by Kibana app and most will move out soon
-/src/plugins/home/public @elastic/kibana-app
-/src/plugins/home/server/*.ts @elastic/kibana-app
-/src/plugins/home/server/services/ @elastic/kibana-app
-# Exclude tutorial resources folder for now because they are not owned by Kibana app and most will move out soon
-/src/legacy/core_plugins/kibana/public/home/*.ts @elastic/kibana-app
-/src/legacy/core_plugins/kibana/public/home/*.scss @elastic/kibana-app
-/src/legacy/core_plugins/kibana/public/home/np_ready/ @elastic/kibana-app
 /src/plugins/kibana_legacy/ @elastic/kibana-app
 /src/plugins/timelion/ @elastic/kibana-app
-/src/plugins/dev_tools/ @elastic/kibana-app
 /src/plugins/dashboard/ @elastic/kibana-app
+/src/plugins/discover/ @elastic/kibana-app
+
+# Core UI
+# Exclude tutorials folder for now because they are not owned by Kibana app and most will move out soon
+/src/plugins/home/public @elastic/kibana-core-ui
+/src/plugins/home/server/*.ts @elastic/kibana-core-ui
+/src/plugins/home/server/services/ @elastic/kibana-core-ui
+# Exclude tutorial resources folder for now because they are not owned by Kibana app and most will move out soon
+/src/legacy/core_plugins/kibana/public/home/*.ts @elastic/kibana-core-ui
+/src/legacy/core_plugins/kibana/public/home/*.scss @elastic/kibana-core-ui
+/src/legacy/core_plugins/kibana/public/home/np_ready/ @elastic/kibana-core-ui
 
 # App Architecture
 /examples/url_generators_examples/ @elastic/kibana-app-arch
@@ -85,9 +87,8 @@
 /x-pack/test/functional/apps/machine_learning/  @elastic/ml-ui
 /x-pack/test/functional/services/machine_learning/  @elastic/ml-ui
 /x-pack/test/functional/services/ml.ts  @elastic/ml-ui
-# ML team owns the transform plugin, ES team added here for visibility
-# because the plugin lives in Kibana's Elasticsearch management section.
-/x-pack/plugins/transform/  @elastic/ml-ui @elastic/es-ui
+# ML team owns and maintains the transform plugin despite it living in the Elasticsearch management section.
+/x-pack/plugins/transform/  @elastic/ml-ui
 /x-pack/test/functional/apps/transform/ @elastic/ml-ui
 /x-pack/test/functional/services/transform_ui/ @elastic/ml-ui
 /x-pack/test/functional/services/transform.ts @elastic/ml-ui
@@ -175,6 +176,7 @@
 **/*.scss  @elastic/kibana-design
 
 # Elasticsearch UI
+/src/plugins/dev_tools/ @elastic/es-ui
 /src/plugins/console/  @elastic/es-ui
 /src/plugins/es_ui_shared/  @elastic/es-ui
 /x-pack/legacy/plugins/cross_cluster_replication/  @elastic/es-ui

docs/api/role-management/put.asciidoc

@@ -17,6 +17,7 @@ experimental[] Create a new {kib} role, or update the attributes of an existing
 
 To use the create or update role API, you must have the `manage_security` cluster privilege.
 
+[role="child_attributes"]
 [[role-management-api-response-body]]
 ==== Request body
 
@@ -29,8 +30,11 @@ To use the create or update role API, you must have the `manage_security` cluste
   {ref}/defining-roles.html[Defining roles].
 
 `kibana`::
-  (list) Objects that specify the <<kibana-privileges, Kibana privileges>> for the role:
-
+  (list) Objects that specify the <<kibana-privileges, Kibana privileges>> for the role.
++
+.Properties of `kibana`
+[%collapsible%open]
+=====
 `base` :::
   (Optional, list) A base privilege. When specified, the base must be `["all"]` or `["read"]`.
   When the `base` privilege is specified, you are unable to use the `feature` section.
@@ -45,14 +49,15 @@ To use the create or update role API, you must have the `manage_security` cluste
 `spaces` :::
   (list) The spaces to apply the privileges to.
   To grant access to all spaces, set to `["*"]`, or omit the value.
+=====
 
 [[role-management-api-put-response-codes]]
 ==== Response code
 
 `204`::
   Indicates a successful call.
 
-===== Examples
+==== Examples
 
 Grant access to various features in all spaces:
 

docs/api/spaces-management/copy_saved_objects.asciidoc

@@ -26,6 +26,7 @@ You can request to overwrite any objects that already exist in the target space
 `space_id`::
 (Optional, string) The ID of the space that contains the saved objects you want to copy. When `space_id` is unspecified in the URL, the default space is used.
 
+[role="child_attributes"]
 [[spaces-api-copy-saved-objects-request-body]]
 ==== {api-request-body-title}
 
@@ -34,38 +35,60 @@ You can request to overwrite any objects that already exist in the target space
 
 `objects`::
   (Required, object array) The saved objects to copy.
++
+.Properties of `objects`
+[%collapsible%open]
+=====
   `type`:::
     (Required, string) The saved object type.
+
   `id`:::
     (Required, string) The saved object ID.
+=====
 
 `includeReferences`::
   (Optional, boolean) When set to `true`, all saved objects related to the specified saved objects will also be copied into the target spaces. The default value is `false`.
 
 `overwrite`::
   (Optional, boolean) When set to `true`, all conflicts are automatically overidden. When a saved object with a matching `type` and `id` exists in the target space, that version is replaced with the version from the source space. The default value is `false`.
 
-
+[role="child_attributes"]
 [[spaces-api-copy-saved-objects-response-body]]
 ==== {api-response-body-title}
 
 `<space_id>`::
   (object) An object that describes the result of the copy operation for the space. Includes the dynamic keys in the response.
++
+.Properties of `<space_id>`
+[%collapsible%open]
+=====
   `success`:::
     (boolean) The copy operation was successful. When set to `false`, some objects may have been copied. For additional information, refer to the `successCount` and `errors` properties.
+
   `successCount`:::
     (number) The number of objects that successfully copied.
+
   `errors`:::
-    (Optional, array) The errors that occurred during the copy operation. When errors are reported, the `success` flag is set to `false`.v
+    (Optional, array) The errors that occurred during the copy operation. When errors are reported, the `success` flag is set to `false`.
++
+.Properties of `errors`
+[%collapsible%open]
+======
     `id`::::
       (string) The saved object ID that failed to copy.
     `type`::::
       (string) The type of saved object that failed to copy.
     `error`::::
       (object) The error that caused the copy operation to fail.
++
+.Properties of `error`
+[%collapsible%open]
+=======
       `type`:::::
         (string) The type of error. For example, `unsupported_type`, `missing_references`, or `unknown`. Errors marked as `conflict` may be resolved by using the <<spaces-api-resolve-copy-saved-objects-conflicts, Resolve copy saved objects conflicts API>>.
-
+=======
+======
+=====
 [[spaces-api-copy-saved-objects-example]]
 ==== {api-examples-title}
 

docs/api/spaces-management/resolve_copy_saved_objects_conflicts.asciidoc

@@ -25,51 +25,89 @@ Execute the <<spaces-api-copy-saved-objects,copy saved objects to space API>>, w
 `space_id`::
 (Optional, string) The ID of the space that contains the saved objects you want to copy. When `space_id` is unspecified in the URL, the default space is used. The `space_id` must be the same value used during the failed <<spaces-api-copy-saved-objects, copy saved objects to space API>> operation.
 
+[role="child_attributes"]
 [[spaces-api-resolve-copy-saved-objects-conflicts-request-body]]
 ==== {api-request-body-title}
 
 `objects`::
   (Required, object array) The saved objects to copy. The `objects` must be the same values used during the failed <<spaces-api-copy-saved-objects, copy saved objects to space API>> operation.
++
+.Properties of `objects`
+[%collapsible%open]
+=====
   `type`:::
     (Required, string) The saved object type.
+
   `id`:::
     (Required, string) The saved object ID.
+=====
 
 `includeReferences`::
   (Optional, boolean) When set to `true`, all saved objects related to the specified saved objects are copied into the target spaces. The `includeReferences` must be the same values used during the failed <<spaces-api-copy-saved-objects, copy saved objects to space API>> operation. The default value is `false`.
 
 `retries`::
   (Required, object) The retry operations to attempt. Object keys represent the target space IDs.
++
+.Properties of `retries`
+[%collapsible%open]
+=====
   `<space_id>`:::
   (Required, array) The errors to resolve for the specified `<space_id>`.
++
+
+.Properties of `<space_id>`
+[%collapsible%open]
+======
     `type`::::
     (Required, string) The saved object type.
     `id`::::
     (Required, string) The saved object ID.
     `overwrite`::::
     (Required, boolean) When set to `true`, the saved object from the source space (desigated by the <<spaces-api-resolve-copy-saved-objects-conflicts-path-params, `space_id` path parameter>>) overwrites the conflicting object in the destination space. When set to `false`, this does nothing.
+======
+=====
 
-
+[role="child_attributes"]
 [[spaces-api-resolve-copy-saved-objects-conflicts-response-body]]
 ==== {api-response-body-title}
 
 `<space_id>`::
   (object) An object that describes the result of the copy operation for the space. Includes the dynamic keys in the response.
++
+.Properties of `<space_id>`
+[%collapsible%open]
+=====
   `success`:::
     (boolean) The copy operation was successful. When set to `false`, some objects may have been copied. For additional information, refer to the `successCount` and `errors` properties.
+
   `successCount`:::
     (number) The number of objects that successfully copied.
+
   `errors`:::
     (Optional, array) The errors that occurred during the copy operation. When errors are reported, the `success` flag is set to `false`.
++
+
+.Properties of `errors`
+[%collapsible%open]
+======
     `id`::::
       (string) The saved object ID that failed to copy.
+
     `type`::::
       (string) The type of saved object that failed to copy.
+
     `error`::::
       (object) The error that caused the copy operation to fail.
-      `type`:::::
-        (string) The type of error. For example, `unsupported_type`, `missing_references`, or `unknown`.
++
 
+.Properties of `error`
+[%collapsible%open]
+=======
+      `type`::::
+        (string) The type of error. For example, `unsupported_type`, `missing_references`, or `unknown`.
+=======
+======
+=====
 
 [[spaces-api-resolve-copy-saved-objects-conflicts-example]]
 ==== {api-examples-title}

docs/apm/api.asciidoc

@@ -38,17 +38,22 @@ The following Agent configuration APIs are available:
 
 `PUT /api/apm/settings/agent-configuration`
 
+[role="child_attributes"]
 [[apm-update-config-req-body]]
 ===== Request body
 
 `service`::
 (required, object) Service identifying the configuration to create or update.
-
++
+.Properties of `service`
+[%collapsible%open]
+======
 `name` :::
   (required, string) Name of service
 
 `environment` :::
   (optional, string) Environment of service
+======
 
 `settings`::
 (required) Key/value object with settings and their corresponding value.
@@ -90,16 +95,21 @@ PUT /api/apm/settings/agent-configuration
 
 `DELETE /api/apm/settings/agent-configuration`
 
+[role="child_attributes"]
 [[apm-delete-config-req-body]]
 ===== Request body
 `service`::
 (required, object) Service identifying the configuration to delete
-
++
+.Properties of `service`
+[%collapsible%open]
+======
 `name` :::
   (required, string) Name of service
 
 `environment` :::
   (optional, string) Environment of service
+======
 
 
 [[apm-delete-config-example]]
@@ -201,17 +211,22 @@ GET  /api/apm/settings/agent-configuration
 
 `POST /api/apm/settings/agent-configuration/search`
 
+[role="child_attributes"]
 [[apm-search-config-req-body]]
 ===== Request body
 
 `service`::
 (required, object) Service identifying the configuration.
-
++
+.Properties of `service`
+[%collapsible%open]
+======
 `name` :::
   (required, string) Name of service
 
 `environment` :::
   (optional, string) Environment of service
+======
 
 `etag`::
 (required) etag is sent by the agent to indicate the etag of the last successfully applied configuration. If the etag matches an existing configuration its `applied_by_agent` property will be set to `true`. Every time a configuration is edited `applied_by_agent` is reset to `false`.

docs/apm/transactions.asciidoc

@@ -103,9 +103,7 @@ The number of requests per bucket is displayed when hovering over the graph, and
 [role="screenshot"]
 image::apm/images/apm-transaction-duration-dist.png[Example view of transactions duration distribution graph]
 
-Most of the requests fall into buckets on the left side of the graph,
-with a long tail of smaller buckets to the right.
-This is a typical distribution, and indicates most of our requests were served quickly - awesome!
+This graph shows a typical distribution, and indicates most of our requests were served quickly - awesome!
 It's the requests on the right, the ones taking longer than average, that we probably want to focus on.
 When you select one of these buckets,
 you're presented with up to ten trace samples.

docs/canvas/canvas-elements.asciidoc

@@ -138,7 +138,9 @@ To apply CSS overrides:
 
 . Next to *Element style*, click *+*, then select *CSS*.
 
-. Enter the *CSS*. For example, to center the Markdown element, enter:
+. Enter the *CSS*.
++
+For example, to center the Markdown element, enter:
 +
 [source,text]
 --------------------------------------------------