pauls comments

elastic · Jun 2, 2020 · 635d035 · 635d035
1 parent 4f4e14c
commit 635d035
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 9 deletions.
diff --git a/x-pack/plugins/ingest_manager/common/types/models/datasource.ts b/x-pack/plugins/ingest_manager/common/types/models/datasource.ts
@@ -43,9 +43,6 @@ export interface DatasourceInput extends Omit<NewDatasourceInput, 'streams'> {
   streams: DatasourceInputStream[];
 }
 
-/**
- * Type of `datasource` prop in CustomConfigureDatasourceContent
- */
 export interface NewDatasource {
   name: string;
   description?: string;

diff --git a/x-pack/plugins/ingest_manager/public/index.ts b/x-pack/plugins/ingest_manager/public/index.ts
@@ -12,6 +12,9 @@ export const plugin = (initializerContext: PluginInitializerContext) => {
   return new IngestManagerPlugin(initializerContext);
 };
 
-export { CustomConfigureDatasourceContent } from './applications/ingest_manager/sections/agent_config/create_datasource_page/components/custom_configure_datasource';
+export {
+  CustomConfigureDatasourceContent,
+  CustomConfigureDatasourceProps,
+} from './applications/ingest_manager/sections/agent_config/create_datasource_page/components/custom_configure_datasource';
 
 export { NewDatasource } from './applications/ingest_manager/types';
diff --git a/x-pack/plugins/siem/public/index.ts b/x-pack/plugins/siem/public/index.ts
@@ -12,8 +12,4 @@ export const plugin = (context: PluginInitializerContext): Plugin => new Plugin(
 
 export { Plugin, PluginSetup, PluginStart };
 
-/**
- * Exports Endpoint-specific datasource configuration instructions
- * for use in the Ingest app create / edit datasource config
- */
 export { ConfigureEndpointDatasource } from './management/pages/policy/view/ingest_manager_integration/configure_datasource';
diff --git a/...m/public/management/pages/policy/view/ingest_manager_integration/configure_datasource.tsx b/...m/public/management/pages/policy/view/ingest_manager_integration/configure_datasource.tsx
@@ -11,6 +11,7 @@ import { useKibana } from '../../../../../../../../../src/plugins/kibana_react/p
 import { LinkToApp } from '../../../../../common/components/endpoint/link_to_app';
 import {
   CustomConfigureDatasourceContent,
+  CustomConfigureDatasourceProps,
   NewDatasource,
 } from '../../../../../../../ingest_manager/public';
 import { getManagementUrl } from '../../../..';
@@ -22,7 +23,13 @@ type DatasourceWithId = NewDatasource & { id: string };
  * for use in the Ingest app create / edit datasource config
  */
 export const ConfigureEndpointDatasource = memo<CustomConfigureDatasourceContent>(
-  ({ from, datasource }: { from: string; datasource: NewDatasource | DatasourceWithId }) => {
+  ({
+    from,
+    datasource,
+  }: {
+    from: string;
+    datasource: CustomConfigureDatasourceProps['datasource'];
+  }) => {
     const { services } = useKibana();
     let policyUrl = '';
     if (from === 'edit') {