fix render loop when multiple group rows get expanded

elastic · Oct 3, 2023 · 6587927 · 6587927
1 parent a8bb5cf
commit 6587927
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/...ops/public/components/log_rate_analysis_results_table/log_rate_analysis_results_table.tsx b/...ops/public/components/log_rate_analysis_results_table/log_rate_analysis_results_table.tsx
@@ -91,7 +91,9 @@ export const LogRateAnalysisResultsTable: FC<LogRateAnalysisResultsTableProps> =
   const dataViewId = dataView.id;
 
   const {
+    pinnedGroup,
     pinnedSignificantTerm,
+    selectedGroup,
     selectedSignificantTerm,
     setPinnedSignificantTerm,
     setSelectedSignificantTerm,
@@ -404,7 +406,9 @@ export const LogRateAnalysisResultsTable: FC<LogRateAnalysisResultsTableProps> =
       (selectedSignificantTerm === null ||
         !pageOfItems.some((item) => isEqual(item, selectedSignificantTerm))) &&
       pinnedSignificantTerm === null &&
-      pageOfItems.length > 0
+      pageOfItems.length > 0 &&
+      selectedGroup === null &&
+      pinnedGroup === null
     ) {
       setSelectedSignificantTerm(pageOfItems[0]);
     }
@@ -413,15 +417,19 @@ export const LogRateAnalysisResultsTable: FC<LogRateAnalysisResultsTableProps> =
     // on the current page, set the status of pinned rows back to `null`.
     if (
       pinnedSignificantTerm !== null &&
-      !pageOfItems.some((item) => isEqual(item, pinnedSignificantTerm))
+      !pageOfItems.some((item) => isEqual(item, pinnedSignificantTerm)) &&
+      selectedGroup === null &&
+      pinnedGroup === null
     ) {
       setPinnedSignificantTerm(null);
     }
   }, [
+    selectedGroup,
     selectedSignificantTerm,
     setSelectedSignificantTerm,
     setPinnedSignificantTerm,
     pageOfItems,
+    pinnedGroup,
     pinnedSignificantTerm,
   ]);