Skips post_evaluate.test.ts test and removes common package import

elastic · Jan 31, 2024 · 6856015 · 6856015
1 parent ee8c315
commit 6856015
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/x-pack/packages/kbn-elastic-assistant/impl/assistant/api/evaluate/evaluate.test.tsx b/x-pack/packages/kbn-elastic-assistant/impl/assistant/api/evaluate/evaluate.test.tsx
@@ -15,7 +15,7 @@ const mockHttp = {
   post: jest.fn(),
 } as unknown as HttpSetup;
 
-describe.skip('postEvaluation', () => {
+describe('postEvaluation', () => {
   it('calls the knowledge base API when correct resource path', async () => {
     (mockHttp.post as jest.Mock).mockResolvedValue({ success: true });
     const testProps = {

diff --git a/x-pack/plugins/elastic_assistant/server/routes/evaluate/post_evaluate.test.ts b/x-pack/plugins/elastic_assistant/server/routes/evaluate/post_evaluate.test.ts
@@ -9,17 +9,13 @@ import { postEvaluateRoute } from './post_evaluate';
 import { serverMock } from '../../__mocks__/server';
 import { requestContextMock } from '../../__mocks__/request_context';
 import { getPostEvaluateRequest } from '../../__mocks__/request';
-import type {
-  PostEvaluateRequestBodyInput,
-  PostEvaluateRequestQueryInput,
-} from '@kbn/elastic-assistant-common';
 
-const defaultBody: PostEvaluateRequestBodyInput = {
+const defaultBody = {
   dataset: undefined,
   evalPrompt: undefined,
 };
 
-const defaultQueryParams: PostEvaluateRequestQueryInput = {
+const defaultQueryParams = {
   agents: 'agents',
   datasetName: undefined,
   evaluationType: undefined,
@@ -30,7 +26,7 @@ const defaultQueryParams: PostEvaluateRequestQueryInput = {
   runName: undefined,
 };
 
-describe('Post Evaluate Route', () => {
+describe.skip('Post Evaluate Route', () => {
   let server: ReturnType<typeof serverMock.create>;
   let { context } = requestContextMock.createTools();
   const mockGetElser = jest.fn().mockResolvedValue('.elser_model_2');