Skip to content

Commit

Permalink
Kibana-related packages (#11308)
Browse files Browse the repository at this point in the history
* Make sure package is published under @elastic org namespace

* Preparing packages/ for Kibana-related packages

* Folder structure mirrors package name

* Add note on naming consistency

* s/packages/node modules/ for removing potention confusion with Kibana system packages

* Prefixing the eslint rule with package scope (i.e. org namespace)

* Adding README

* Bumping up version for release

* Adding repository information to package.json

* Bumping up version for release

* URL-encoding repository link + bumping up version for release

* Using published version
  • Loading branch information
ycombinator committed Apr 19, 2017
1 parent a605b7f commit 69c2288
Show file tree
Hide file tree
Showing 7 changed files with 20 additions and 7 deletions.
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -217,7 +217,7 @@
"eslint": "3.11.1",
"eslint-plugin-babel": "4.0.0",
"eslint-plugin-jest": "19.0.1",
"eslint-plugin-kibana-custom": "file:packages/custom-eslint-rules",
"@elastic/eslint-plugin-kibana-custom": "1.0.3",
"eslint-plugin-mocha": "4.7.0",
"eslint-plugin-react": "6.10.3",
"event-stream": "3.3.2",
Expand Down
3 changes: 3 additions & 0 deletions packages/@elastic/eslint-plugin-kibana-custom/README.md
@@ -0,0 +1,3 @@
# Custom ESLint rules for Kibana

This package contains custom ESLint rules used for Kibana development.
File renamed without changes.
9 changes: 9 additions & 0 deletions packages/@elastic/eslint-plugin-kibana-custom/package.json
@@ -0,0 +1,9 @@
{
"name": "@elastic/eslint-plugin-kibana-custom",
"version": "1.0.3",
"description": "Custom ESLint rules for Kibana",
"repository": {
"type": "git",
"url": "https://github.com/elastic/kibana/tree/master/packages/%40elastic/eslint-plugin-kibana-custom"
}
}
6 changes: 6 additions & 0 deletions packages/README.md
@@ -0,0 +1,6 @@
## Kibana-related node modules

This folder contains node modules that are created by Kibana developers, for use in Kibana and its plugins.

For each such node module, create a sub-folder in this folder. The path/name of the folder should mirror the `name` in the node module's `package.json`. To publish the node module as an npm package, `cd` into the package's sub-folder, and run `npm publish` as usual.

5 changes: 0 additions & 5 deletions packages/custom-eslint-rules/package.json

This file was deleted.

2 changes: 1 addition & 1 deletion src/core_plugins/kibana/public/.eslintrc
@@ -1,6 +1,6 @@

plugins: [
'kibana-custom'
'@elastic/kibana-custom'
]
rules:
no-console: 2
Expand Down

0 comments on commit 69c2288

Please sign in to comment.