fix types

elastic · Apr 18, 2023 · 6fee2b8 · 6fee2b8
1 parent 01458a8
commit 6fee2b8
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 4 deletions.
diff --git a/x-pack/plugins/aiops/public/application/utils/url_state.ts b/x-pack/plugins/aiops/public/application/utils/url_state.ts
@@ -8,6 +8,7 @@
 import type * as estypes from '@elastic/elasticsearch/lib/api/typesWithBodyKey';
 
 import type { Filter, Query } from '@kbn/es-query';
+import { isPopulatedObject } from '@kbn/ml-is-populated-object';
 
 import { SEARCH_QUERY_LANGUAGE, SearchQueryLanguage } from './search_utils';
 
@@ -27,12 +28,18 @@ export interface AiOpsIndexBasedAppState {
   filters?: Filter[];
 }
 
+export type AiOpsFullIndexBasedAppState = Required<AiOpsIndexBasedAppState>;
+
 export const getDefaultAiOpsListState = (
   overrides?: Partial<AiOpsIndexBasedAppState>
-): Required<AiOpsIndexBasedAppState> => ({
+): AiOpsFullIndexBasedAppState => ({
   searchString: '',
   searchQuery: defaultSearchQuery,
   searchQueryLanguage: SEARCH_QUERY_LANGUAGE.KUERY,
   filters: [],
   ...overrides,
 });
+
+export const isFullAiOpsListState = (arg: unknown): arg is AiOpsFullIndexBasedAppState => {
+  return isPopulatedObject(arg, Object.keys(getDefaultAiOpsListState()));
+};
diff --git a/x-pack/plugins/aiops/public/components/log_categorization/category_table/category_table.tsx b/x-pack/plugins/aiops/public/components/log_categorization/category_table/category_table.tsx
@@ -25,7 +25,7 @@ import {
 import { useDiscoverLinks } from '../use_discover_links';
 import { MiniHistogram } from '../../mini_histogram';
 import { useEuiTheme } from '../../../hooks/use_eui_theme';
-import type { AiOpsIndexBasedAppState } from '../../../application/utils/url_state';
+import type { AiOpsFullIndexBasedAppState } from '../../../application/utils/url_state';
 import type { EventRate, Category, SparkLinesPerCategory } from '../use_categorize_request';
 import { useTableState } from './use_table_state';
 
@@ -42,7 +42,7 @@ interface Props {
   dataViewId: string;
   selectedField: string | undefined;
   timefilter: TimefilterContract;
-  aiopsListState: Required<AiOpsIndexBasedAppState>;
+  aiopsListState: AiOpsFullIndexBasedAppState;
   pinnedCategory: Category | null;
   setPinnedCategory: (category: Category | null) => void;
   selectedCategory: Category | null;

diff --git a/x-pack/plugins/aiops/public/components/log_categorization/log_categorization_page.tsx b/x-pack/plugins/aiops/public/components/log_categorization/log_categorization_page.tsx
@@ -31,6 +31,7 @@ import type { SearchQueryLanguage } from '../../application/utils/search_utils';
 import { useAiopsAppContext } from '../../hooks/use_aiops_app_context';
 import {
   getDefaultAiOpsListState,
+  isFullAiOpsListState,
   type AiOpsPageUrlState,
 } from '../../application/utils/url_state';
 
@@ -296,7 +297,10 @@ export const LogCategorizationPage: FC = () => {
         fieldSelected={selectedField !== null}
       />
 
-      {selectedField !== undefined && categories !== null && categories.length > 0 ? (
+      {selectedField !== undefined &&
+      categories !== null &&
+      categories.length > 0 &&
+      isFullAiOpsListState(aiopsListState) ? (
         <CategoryTable
           categories={categories}
           aiopsListState={aiopsListState}