ensure job id string is corrrect

elastic · Nov 16, 2023 · 73216d0 · 73216d0
1 parent 3bc2c8d
commit 73216d0
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/x-pack/plugins/ml/server/routes/trained_models.ts b/x-pack/plugins/ml/server/routes/trained_models.ts
@@ -193,17 +193,18 @@ export function trainedModelsRoutes(
           const filteredModels = filterForEnabledFeatureModels(result, getEnabledFeatures());
 
           try {
-            const jobIdsString = filteredModels.reduce((jobIdsStr, currentModel, idx) => {
-              let id = currentModel.metadata?.analytics_config?.id ?? '';
-              if (id !== '') {
-                id = `${idx > 0 ? ',' : ''}${id}*`;
-              }
-              return `${jobIdsStr}${id}`;
-            }, '');
+            const jobIds = filteredModels
+              .map((model) => {
+                const id = model.metadata?.analytics_config?.id;
+                if (id) {
+                  return `${id}*`;
+                }
+              })
+              .filter((id) => id !== undefined);
 
-            if (jobIdsString !== '') {
+            if (jobIds.length) {
               const { data_frame_analytics: jobs } = await mlClient.getDataFrameAnalytics({
-                id: jobIdsString,
+                id: jobIds.join(','),
                 allow_no_match: true,
               });