fix functional tests

elastic · Mar 17, 2022 · 7d0cc59 · 7d0cc59
1 parent 7c07124
commit 7d0cc59
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 12 deletions.
diff --git a/x-pack/test/functional/apps/lens/add_to_dashboard.ts b/x-pack/test/functional/apps/lens/add_to_dashboard.ts
@@ -59,6 +59,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
     await listingTable.searchForItemWithName('Artistpreviouslyknownaslens');
     await PageObjects.lens.clickVisualizeListItemTitle('Artistpreviouslyknownaslens');
     await PageObjects.lens.goToTimeRange();
+    await PageObjects.lens.waitForVisualization('mtrVis');
     await PageObjects.lens.assertMetric('Maximum of bytes', '19,986');
   };
 

diff --git a/x-pack/test/functional/apps/lens/runtime_fields.ts b/x-pack/test/functional/apps/lens/runtime_fields.ts
@@ -20,15 +20,17 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       await PageObjects.visualize.clickVisType('lens');
       await PageObjects.lens.goToTimeRange();
       await PageObjects.lens.switchToVisualization('lnsDatatable');
-      await PageObjects.lens.clickAddField();
-      await fieldEditor.setName('runtimefield');
-      await fieldEditor.enableValue();
-      await fieldEditor.typeScript("emit('abc')");
-      await fieldEditor.save();
-      await PageObjects.header.waitUntilLoadingHasFinished();
-      await PageObjects.lens.searchField('runtime');
-      await PageObjects.lens.waitForField('runtimefield');
-      await PageObjects.lens.dragFieldToWorkspace('runtimefield');
+      await retry.try(async () => {
+        await PageObjects.lens.clickAddField();
+        await fieldEditor.setName('runtimefield');
+        await fieldEditor.enableValue();
+        await fieldEditor.typeScript("emit('abc')");
+        await fieldEditor.save();
+        await PageObjects.header.waitUntilLoadingHasFinished();
+        await PageObjects.lens.searchField('runtime');
+        await PageObjects.lens.waitForField('runtimefield');
+        await PageObjects.lens.dragFieldToWorkspace('runtimefield');
+      });
       await PageObjects.lens.waitForVisualization();
       expect(await PageObjects.lens.getDatatableHeaderText(0)).to.equal(
         'Top values of runtimefield'

diff --git a/x-pack/test/functional/page_objects/lens_page.ts b/x-pack/test/functional/page_objects/lens_page.ts
@@ -254,9 +254,7 @@ export function LensPageProvider({ getService, getPageObjects }: FtrProviderCont
     },
 
     async waitForField(field: string) {
-      await retry.try(async () => {
-        await testSubjects.existOrFail(`lnsFieldListPanelField-${field}`);
-      });
+      await testSubjects.existOrFail(`lnsFieldListPanelField-${field}`);
     },
 
     async waitForMissingDataViewWarning() {