review: better readability

elastic · Jul 2, 2024 · 801c314 · 801c314
1 parent 1c07c65
commit 801c314
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 8 deletions.
diff --git a/x-pack/plugins/security_solution/public/common/components/header_actions/actions.tsx b/x-pack/plugins/security_solution/public/common/components/header_actions/actions.tsx
@@ -213,7 +213,7 @@ const ActionsComponent: React.FC<ActionProps> = ({
   }, [activeStep, incrementStep, isTourAnchor, isTourShown, onEventDetailsPanelOpened]);
 
   const noteIds = useMemo(
-    () => (eventIdToNoteIds ? eventIdToNoteIds[eventId] || emptyNotes : emptyNotes),
+    () => eventIdToNoteIds?.[eventId] ?? emptyNotes,
     [eventIdToNoteIds, eventId]
   );
 

diff --git a/.../security_solution/public/timelines/components/timeline/properties/use_notes_in_flyout.ts b/.../security_solution/public/timelines/components/timeline/properties/use_notes_in_flyout.ts
@@ -45,7 +45,7 @@ export const useNotesInFlyout = (args: UseNotesInFlyoutArgs) => {
   const dispatch = useDispatch();
 
   const noteIds: string[] = useMemo(
-    () => (eventIdToNoteIds && eventId && eventIdToNoteIds[eventId]) || EMPTY_STRING_ARRAY,
+    () => (eventId && eventIdToNoteIds?.[eventId]) || EMPTY_STRING_ARRAY,
     [eventIdToNoteIds, eventId]
   );
 

diff --git a/...ity_solution/public/timelines/components/timeline/unified_components/data_table/index.tsx b/...ity_solution/public/timelines/components/timeline/unified_components/data_table/index.tsx
@@ -400,6 +400,14 @@ export const TimelineDataTableComponent: React.FC<DataTableProps> = memo(
       };
     }, [expandedDoc]);
 
+    const finalRenderCustomBodyCallback = useMemo(() => {
+      return enabledRowRenderers.length > 0 ? renderCustomBodyCallback : undefined;
+    }, [enabledRowRenderers.length, renderCustomBodyCallback]);
+
+    const finalTrailControlColumns = useMemo(() => {
+      return enabledRowRenderers.length > 0 ? trailingControlColumns : undefined;
+    }, [enabledRowRenderers.length, trailingControlColumns]);
+
     return (
       <StatefulEventContext.Provider value={activeStatefulEventContext}>
         <StyledTimelineUnifiedDataTable>
@@ -449,12 +457,8 @@ export const TimelineDataTableComponent: React.FC<DataTableProps> = memo(
             showMultiFields={true}
             cellActionsMetadata={cellActionsMetadata}
             externalAdditionalControls={additionalControls}
-            renderCustomGridBody={
-              enabledRowRenderers.length > 0 ? renderCustomBodyCallback : undefined
-            }
-            trailingControlColumns={
-              enabledRowRenderers.length > 0 ? trailingControlColumns : undefined
-            }
+            renderCustomGridBody={finalRenderCustomBodyCallback}
+            trailingControlColumns={finalTrailControlColumns}
             externalControlColumns={leadingControlColumns}
             cellContext={cellContext}
           />