Use custom panels for data-title attributes

elastic · Nov 16, 2017 · 80d33d2 · 80d33d2
1 parent a7c91cd
commit 80d33d2
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 2 deletions.
diff --git a/src/core_plugins/kibana/public/discover/embeddable/search_embeddable_factory.js b/src/core_plugins/kibana/public/discover/embeddable/search_embeddable_factory.js
@@ -31,6 +31,7 @@ export class SearchEmbeddableFactory extends EmbeddableFactory {
     searchScope.editPath = this.getEditPath(panel.id);
     return this.searchLoader.get(panel.id)
       .then(savedObject => {
+        searchScope.sharedItemTitle = panel.title !== undefined ? panel.title : savedObject.title;
         searchScope.savedObj = savedObject;
         searchScope.panel = panel;
         container.registerPanelIndexPattern(panel.panelIndex, savedObject.searchSource.get('index'));

diff --git a/src/core_plugins/kibana/public/discover/embeddable/search_template.html b/src/core_plugins/kibana/public/discover/embeddable/search_template.html
@@ -3,7 +3,7 @@
   sorting="sort"
   columns="columns"
   data-shared-item
-  data-title="{{savedObj.title}}"
+  data-title="{{sharedItemTitle}}"
   data-description="{{savedObj.description}}"
   render-counter
   class="panel-content"

diff --git a/src/core_plugins/kibana/public/visualize/embeddable/visualize_embeddable_factory.js b/src/core_plugins/kibana/public/visualize/embeddable/visualize_embeddable_factory.js
@@ -30,6 +30,7 @@ export class VisualizeEmbeddableFactory extends EmbeddableFactory {
     visualizeScope.editUrl = this.getEditPath(panel.id);
     return this.visualizeLoader.get(panel.id)
       .then(savedObject => {
+        visualizeScope.sharedItemTitle = panel.title !== undefined ? panel.title : savedObject.title;
         visualizeScope.savedObj = savedObject;
         visualizeScope.panel = panel;
 

diff --git a/src/core_plugins/kibana/public/visualize/embeddable/visualize_template.html b/src/core_plugins/kibana/public/visualize/embeddable/visualize_template.html
@@ -4,7 +4,7 @@
   app-state="appState"
   ui-state="uiState"
   data-shared-item
-  data-title="{{savedObj.title}}"
+  data-title="{{sharedItemTitle}}"
   data-description="{{savedObj.description}}"
   render-counter
   class="panel-content">