Skip to content

Commit

Permalink
Fix treeshake on shared-ux packages (#182790)
Browse files Browse the repository at this point in the history
## Summary

This PR should fix some regression due to some previous tree-shake
configs from #182348 .
The fix tells now webpack to always import css, so final bundle size
will increase back again (not all of it, but a good 70%).
  • Loading branch information
dej611 committed May 8, 2024
1 parent eb5e329 commit 810e820
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion packages/shared-ux/avatar/solution/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
"sideEffects": ["*.scss"]
}
2 changes: 1 addition & 1 deletion packages/shared-ux/button/exit_full_screen/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
"sideEffects": ["*.scss"]
}
2 changes: 1 addition & 1 deletion packages/shared-ux/chrome/navigation/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
"sideEffects": ["*.scss"]
}
2 changes: 1 addition & 1 deletion packages/shared-ux/file/file_picker/impl/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
"sideEffects": ["*.scss"]
}
2 changes: 1 addition & 1 deletion packages/shared-ux/page/solution_nav/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
"sideEffects": ["*.scss"]
}

0 comments on commit 810e820

Please sign in to comment.