Skip to content

Commit

Permalink
unskip filtering tests (#21804)
Browse files Browse the repository at this point in the history
* unskip filtering tests

* always navigate to landing page when trying to load a dashboard up

* more post test clean up - unpin the filter or it'll stick around for other tests.
  • Loading branch information
stacey-gammon committed Aug 18, 2018
1 parent 068d82d commit 8bc717f
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
10 changes: 7 additions & 3 deletions test/functional/apps/dashboard/_dashboard_filtering.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export default function ({ getService, getPageObjects }) {
await PageObjects.dashboard.gotoDashboardLandingPage();
});

describe.skip('adding a filter that excludes all data', async () => {
describe('adding a filter that excludes all data', async () => {
before(async () => {
await PageObjects.dashboard.clickNewDashboard();
await PageObjects.dashboard.setTimepickerInDataRange();
Expand Down Expand Up @@ -102,13 +102,17 @@ export default function ({ getService, getPageObjects }) {
});
});

describe.skip('using a pinned filter that excludes all data', async () => {
describe('using a pinned filter that excludes all data', async () => {
before(async () => {
await filterBar.toggleFilterPinned('bytes');
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.dashboard.waitForRenderComplete();
});

after(async () => {
await filterBar.toggleFilterPinned('bytes');
});

it('filters on pie charts', async () => {
await dashboardExpect.pieSliceCount(0);
});
Expand Down Expand Up @@ -159,7 +163,7 @@ export default function ({ getService, getPageObjects }) {
});
});

describe.skip('disabling a filter unfilters the data on', async () => {
describe('disabling a filter unfilters the data on', async () => {
before(async () => {
await testSubjects.click('disableFilter-bytes');
await PageObjects.header.waitUntilLoadingHasFinished();
Expand Down
2 changes: 2 additions & 0 deletions test/functional/page_objects/dashboard_page.js
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,8 @@ export function DashboardPageProvider({ getService, getPageObjects }) {
async loadSavedDashboard(dashName) {
log.debug(`Load Saved Dashboard ${dashName}`);

await this.gotoDashboardLandingPage();

await retry.try(async () => {
await this.searchForDashboardWithName(dashName);
await this.selectDashboard(dashName);
Expand Down

0 comments on commit 8bc717f

Please sign in to comment.