functional tests for fallback with dip

elastic · Nov 29, 2023 · 8c5c3f6 · 8c5c3f6
1 parent 10539cb
commit 8c5c3f6
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 5 deletions.
diff --git a/...t/functional/apps/aiops/log_rate_analysis/test_data/artificial_log_data_view_test_data.ts b/...t/functional/apps/aiops/log_rate_analysis/test_data/artificial_log_data_view_test_data.ts
@@ -88,10 +88,18 @@ export const getArtificialLogDataViewTestData = ({
   }
 
   function getBrushBaselineTargetTimestamp() {
+    if (analysisType === 'dip' && gaps) {
+      return DEVIATION_TS;
+    }
+
     return gaps ? BASELINE_TS - DAY_MS / 2 : BASELINE_TS + DAY_MS / 2;
   }
 
   function getBrushDeviationTargetTimestamp() {
+    if (analysisType === 'dip' && gaps) {
+      return DEVIATION_TS + DAY_MS * 1.5;
+    }
+
     return gaps ? DEVIATION_TS : DEVIATION_TS + DAY_MS / 2;
   }
 

diff --git a/x-pack/test/functional/apps/aiops/log_rate_analysis_test_data.ts b/x-pack/test/functional/apps/aiops/log_rate_analysis_test_data.ts
@@ -28,6 +28,16 @@ export const logRateAnalysisTestData: TestData[] = [
     textField: true,
     gaps: false,
   }),
+  getArtificialLogDataViewTestData({
+    analysisType: LOG_RATE_ANALYSIS_TYPE.DIP,
+    textField: false,
+    gaps: false,
+  }),
+  getArtificialLogDataViewTestData({
+    analysisType: LOG_RATE_ANALYSIS_TYPE.DIP,
+    textField: true,
+    gaps: false,
+  }),
   getArtificialLogDataViewTestData({
     analysisType: LOG_RATE_ANALYSIS_TYPE.SPIKE,
     textField: true,
@@ -40,12 +50,12 @@ export const logRateAnalysisTestData: TestData[] = [
   }),
   getArtificialLogDataViewTestData({
     analysisType: LOG_RATE_ANALYSIS_TYPE.DIP,
-    textField: false,
-    gaps: false,
+    textField: true,
+    gaps: true,
   }),
   getArtificialLogDataViewTestData({
     analysisType: LOG_RATE_ANALYSIS_TYPE.DIP,
-    textField: true,
-    gaps: false,
+    textField: false,
+    gaps: true,
   }),
 ];
diff --git a/x-pack/test/functional/services/aiops/log_rate_analysis_data_generator.ts b/x-pack/test/functional/services/aiops/log_rate_analysis_data_generator.ts
@@ -295,10 +295,14 @@ export function LogRateAnalysisDataGeneratorProvider({ getService }: FtrProvider
           });
 
           const dataGeneratorOptions = dataGenerator.split('_');
-          const deviationType = dataGeneratorOptions[3] ?? LOG_RATE_ANALYSIS_TYPE.SPIKE;
+          let deviationType = dataGeneratorOptions[3] ?? LOG_RATE_ANALYSIS_TYPE.SPIKE;
           const textField = dataGeneratorOptions[4] === 'textfield' ?? false;
           const gaps = dataGeneratorOptions[5] === 'gaps' ?? false;
 
+          if (gaps) {
+            deviationType = LOG_RATE_ANALYSIS_TYPE.SPIKE;
+          }
+
           await es.bulk({
             refresh: 'wait_for',
             body: getArtificialLogsWithDeviation(dataGenerator, deviationType, textField, gaps),