async load js-sha256

elastic · Jul 20, 2021 · 8ccd241 · 8ccd241
1 parent fc1a52b
commit 8ccd241
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 8 deletions.
diff --git a/x-pack/plugins/cloud/public/fullstory.ts b/x-pack/plugins/cloud/public/fullstory.ts
@@ -5,6 +5,7 @@
  * 2.0.
  */
 
+import { sha256 } from 'js-sha256'; // loaded here to reduce page load bundle size when FullStory is disabled
 import type { IBasePath, PackageInfo } from '../../../../src/core/public';
 
 export interface FullStoryDeps {
@@ -18,11 +19,16 @@ export interface FullStoryApi {
   event(eventName: string, eventProperties: Record<string, any>): void;
 }
 
+export interface FullStoryService {
+  fullStory: FullStoryApi;
+  sha256: typeof sha256;
+}
+
 export const initializeFullStory = ({
   basePath,
   orgId,
   packageInfo,
-}: FullStoryDeps): FullStoryApi => {
+}: FullStoryDeps): FullStoryService => {
   // @ts-expect-error
   window._fs_debug = false;
   // @ts-expect-error
@@ -72,5 +78,8 @@ export const initializeFullStory = ({
   // @ts-expect-error
   const fullStory: FullStoryApi = window.FSKibana;
 
-  return fullStory;
+  return {
+    fullStory,
+    sha256,
+  };
 };
diff --git a/x-pack/plugins/cloud/public/plugin.test.mocks.ts b/x-pack/plugins/cloud/public/plugin.test.mocks.ts
@@ -5,15 +5,17 @@
  * 2.0.
  */
 
-import type { FullStoryDeps, FullStoryApi } from './fullstory';
+import { sha256 } from 'js-sha256';
+import type { FullStoryDeps, FullStoryApi, FullStoryService } from './fullstory';
 
 export const fullStoryApiMock: jest.Mocked<FullStoryApi> = {
   event: jest.fn(),
   identify: jest.fn(),
 };
-export const initializeFullStoryMock = jest.fn<FullStoryApi, [FullStoryDeps]>(
-  () => fullStoryApiMock
-);
+export const initializeFullStoryMock = jest.fn<FullStoryService, [FullStoryDeps]>(() => ({
+  fullStory: fullStoryApiMock,
+  sha256,
+}));
 jest.doMock('./fullstory', () => {
   return { initializeFullStory: initializeFullStoryMock };
 });
diff --git a/x-pack/plugins/cloud/public/plugin.ts b/x-pack/plugins/cloud/public/plugin.ts
@@ -14,7 +14,6 @@ import {
   IBasePath,
 } from 'src/core/public';
 import { i18n } from '@kbn/i18n';
-import { sha256 } from 'js-sha256';
 import type {
   AuthenticatedUser,
   SecurityPluginSetup,
@@ -178,7 +177,7 @@ export class CloudPlugin implements Plugin<CloudSetup> {
       userIdPromise,
     ]);
 
-    const fullStory = initializeFullStory({
+    const { fullStory, sha256 } = initializeFullStory({
       basePath,
       orgId,
       packageInfo: this.initializerContext.env.packageInfo,