Add API integration test for 404 condition

elastic · Apr 29, 2021 · 8f1ae02 · 8f1ae02
1 parent d0aca90
commit 8f1ae02
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/x-pack/plugins/security/server/routes/indices/get_fields.ts b/x-pack/plugins/security/server/routes/indices/get_fields.ts
@@ -22,8 +22,8 @@ export function defineGetFieldsRoutes({ router }: RouteDefinitionParams) {
           body: indexMappings,
         } = await context.core.elasticsearch.client.asCurrentUser.indices.getFieldMapping({
           index: request.params.query,
-          allow_no_indices: false,
           fields: '*',
+          allow_no_indices: false,
           include_defaults: true,
           filter_path: '*.mappings.*.mapping.*.type',
         });

diff --git a/x-pack/test/api_integration/apis/security/index_fields.ts b/x-pack/test/api_integration/apis/security/index_fields.ts
@@ -71,6 +71,16 @@ export default function ({ getService }: FtrProviderContext) {
 
         expect(actualFields).to.eql(expectedFields);
       });
+
+      it('should return an empty result for indices that do not exist', async () => {
+        const { body: actualFields } = (await supertest
+          .get('/internal/security/fields/this-index-name-definitely-does-not-exist-*')
+          .set('kbn-xsrf', 'xxx')
+          .send()
+          .expect(200)) as { body: string[] };
+
+        expect(actualFields).to.eql([]);
+      });
     });
   });
 }