Merge branch 'master' into update-ts-lint

docs/developer/architecture/code-exploration.asciidoc

@@ -58,9 +58,9 @@ The Charts plugin is a way to create easier integration of shared colors, themes
 WARNING: Missing README.
 
 
-- {kib-repo}blob/{branch}/src/plugins/dashboard[dashboard]
+- {kib-repo}blob/{branch}/src/plugins/dashboard/README.md[dashboard]
 
-WARNING: Missing README.
+Contains the dashboard application.
 
 
 - {kib-repo}blob/{branch}/src/plugins/data/README.md[data]
@@ -76,9 +76,9 @@ Routing will be handled by the id of the dev tool - your dev tool will be mounte
 This API doesn't support angular, for registering angular dev tools, bootstrap a local module on mount into the given HTML element.
 
 
-- {kib-repo}blob/{branch}/src/plugins/discover[discover]
+- {kib-repo}blob/{branch}/src/plugins/discover/README.md[discover]
 
-WARNING: Missing README.
+Contains the Discover application and the saved search embeddable.
 
 
 - {kib-repo}blob/{branch}/src/plugins/embeddable/README.md[embeddable]
@@ -109,9 +109,9 @@ Moves the legacy ui/registry/feature_catalogue module for registering "features"
 WARNING: Missing README.
 
 
-- {kib-repo}blob/{branch}/src/plugins/input_control_vis[inputControlVis]
+- {kib-repo}blob/{branch}/src/plugins/input_control_vis/README.md[inputControlVis]
 
-WARNING: Missing README.
+Contains the input control visualization allowing to place custom filter controls on a dashboard.
 
 
 - {kib-repo}blob/{branch}/src/plugins/inspector/README.md[inspector]
@@ -206,9 +206,10 @@ This plugin adds the Advanced Settings section for the Usage Data collection (ak
 WARNING: Missing README.
 
 
-- {kib-repo}blob/{branch}/src/plugins/timelion[timelion]
+- {kib-repo}blob/{branch}/src/plugins/timelion/README.md[timelion]
 
-WARNING: Missing README.
+Contains the deprecated timelion application. For the timelion visualization,
+which also contains the timelion APIs and backend, look at the vis_type_timelion plugin.
 
 
 - {kib-repo}blob/{branch}/src/plugins/ui_actions/README.md[uiActions]
@@ -222,59 +223,63 @@ Usage Collection allows collecting usage data for other services to consume (tel
 To integrate with the telemetry services for usage collection of your feature, there are 2 steps:
 
 
-- {kib-repo}blob/{branch}/src/plugins/vis_type_markdown[visTypeMarkdown]
+- {kib-repo}blob/{branch}/src/plugins/vis_type_markdown/README.md[visTypeMarkdown]
 
-WARNING: Missing README.
+The markdown visualization that can be used to place text panels on dashboards.
 
 
-- {kib-repo}blob/{branch}/src/plugins/vis_type_metric[visTypeMetric]
+- {kib-repo}blob/{branch}/src/plugins/vis_type_metric/README.md[visTypeMetric]
 
-WARNING: Missing README.
+Contains the metric visualization.
 
 
-- {kib-repo}blob/{branch}/src/plugins/vis_type_table[visTypeTable]
+- {kib-repo}blob/{branch}/src/plugins/vis_type_table/README.md[visTypeTable]
 
-WARNING: Missing README.
+Contains the data table visualization, that allows presenting data in a simple table format.
 
 
-- {kib-repo}blob/{branch}/src/plugins/vis_type_tagcloud[visTypeTagcloud]
+- {kib-repo}blob/{branch}/src/plugins/vis_type_tagcloud/README.md[visTypeTagcloud]
 
-WARNING: Missing README.
+Contains the tagcloud visualization.
 
 
 - {kib-repo}blob/{branch}/src/plugins/vis_type_timelion/README.md[visTypeTimelion]
 
-If your grammar was changed in public/chain.peg you need to re-generate the static parser. You could use a grunt task:
+Contains the timelion visualization and the timelion backend.
 
 
-- {kib-repo}blob/{branch}/src/plugins/vis_type_timeseries[visTypeTimeseries]
+- {kib-repo}blob/{branch}/src/plugins/vis_type_timeseries/README.md[visTypeTimeseries]
 
-WARNING: Missing README.
+Contains everything around TSVB (the editor, visualizatin implementations and backends).
 
 
-- {kib-repo}blob/{branch}/src/plugins/vis_type_vega[visTypeVega]
+- {kib-repo}blob/{branch}/src/plugins/vis_type_vega/README.md[visTypeVega]
 
-WARNING: Missing README.
+Contains the Vega visualization.
 
 
-- {kib-repo}blob/{branch}/src/plugins/vis_type_vislib[visTypeVislib]
+- {kib-repo}blob/{branch}/src/plugins/vis_type_vislib/README.md[visTypeVislib]
 
-WARNING: Missing README.
+Contains the vislib visualizations. These are the classical area/line/bar, pie, gauge/goal and
+heatmap charts.
 
 
-- {kib-repo}blob/{branch}/src/plugins/vis_type_xy[visTypeXy]
+- {kib-repo}blob/{branch}/src/plugins/vis_type_xy/README.md[visTypeXy]
 
-WARNING: Missing README.
+Contains the new xy-axis chart using the elastic-charts library, which will eventually
+replace the vislib xy-axis (bar, area, line) charts.
 
 
-- {kib-repo}blob/{branch}/src/plugins/visualizations[visualizations]
+- {kib-repo}blob/{branch}/src/plugins/visualizations/README.md[visualizations]
 
-WARNING: Missing README.
+Contains most of the visualization infrastructure, e.g. the visualization type registry or the
+visualization embeddable.
 
 
-- {kib-repo}blob/{branch}/src/plugins/visualize[visualize]
+- {kib-repo}blob/{branch}/src/plugins/visualize/README.md[visualize]
 
-WARNING: Missing README.
+Contains the visualize application which includes the listing page and the app frame,
+which will load the visualization's editor.
 
 
 [discrete]
@@ -345,19 +350,22 @@ You can run a local cluster and simulate a remote cluster within a single Kibana
 
 - {kib-repo}blob/{branch}/x-pack/plugins/dashboard_enhanced/README.md[dashboardEnhanced]
 
-- {kib-repo}blob/{branch}/x-pack/plugins/dashboard_mode[dashboardMode]
+Contains the enhancements to the OSS dashboard app.
 
-WARNING: Missing README.
+
+- {kib-repo}blob/{branch}/x-pack/plugins/dashboard_mode/README.md[dashboardMode]
+
+The deprecated dashboard only mode.
 
 
 - {kib-repo}blob/{branch}/x-pack/plugins/data_enhanced[dataEnhanced]
 
 WARNING: Missing README.
 
 
-- {kib-repo}blob/{branch}/x-pack/plugins/discover_enhanced[discoverEnhanced]
+- {kib-repo}blob/{branch}/x-pack/plugins/discover_enhanced/README.md[discoverEnhanced]
 
-WARNING: Missing README.
+Contains the enhancements to the OSS discover app.
 
 
 - {kib-repo}blob/{branch}/x-pack/plugins/embeddable_enhanced[embeddableEnhanced]

x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/index.ts

@@ -4,4 +4,4 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-export { PipelineFormProvider as PipelineForm } from './pipeline_form_provider';
+export { PipelineForm } from './pipeline_form';

x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form.tsx

@@ -16,7 +16,6 @@ import './pipeline_form.scss';
 import { OnUpdateHandlerArg, OnUpdateHandler } from '../pipeline_processors_editor';
 
 import { PipelineRequestFlyout } from './pipeline_request_flyout';
-import { PipelineTestFlyout } from './pipeline_test_flyout';
 import { PipelineFormFields } from './pipeline_form_fields';
 import { PipelineFormError } from './pipeline_form_error';
 import { pipelineFormSchema } from './schema';
@@ -48,8 +47,6 @@ export const PipelineForm: React.FunctionComponent<PipelineFormProps> = ({
 }) => {
   const [isRequestVisible, setIsRequestVisible] = useState<boolean>(false);
 
-  const [isTestingPipeline, setIsTestingPipeline] = useState<boolean>(false);
-
   const {
     processors: initialProcessors,
     on_failure: initialOnFailureProcessors,
@@ -79,18 +76,13 @@ export const PipelineForm: React.FunctionComponent<PipelineFormProps> = ({
     }
   };
 
-  const handleTestPipelineClick = () => {
-    setIsTestingPipeline(true);
-  };
-
   const { form } = useForm<IPipelineForm>({
     schema: pipelineFormSchema,
     defaultValue: defaultFormValues,
     onSubmit: handleSave,
   });
 
   const onEditorFlyoutOpen = useCallback(() => {
-    setIsTestingPipeline(false);
     setIsRequestVisible(false);
   }, [setIsRequestVisible]);
 
@@ -137,8 +129,6 @@ export const PipelineForm: React.FunctionComponent<PipelineFormProps> = ({
           onFailure={processorsState.onFailure}
           onProcessorsUpdate={onProcessorsChangeHandler}
           hasVersion={Boolean(defaultValue.version)}
-          isTestButtonDisabled={isTestingPipeline || form.isValid === false}
-          onTestPipelineClick={handleTestPipelineClick}
           isEditing={isEditing}
         />
 
@@ -198,18 +188,6 @@ export const PipelineForm: React.FunctionComponent<PipelineFormProps> = ({
             closeFlyout={() => setIsRequestVisible((prevIsRequestVisible) => !prevIsRequestVisible)}
           />
         ) : null}
-
-        {/* Test pipeline flyout */}
-        {isTestingPipeline ? (
-          <PipelineTestFlyout
-            readProcessors={() =>
-              processorStateRef.current?.getData() || { processors: [], on_failure: [] }
-            }
-            closeFlyout={() => {
-              setIsTestingPipeline((prevIsTestingPipeline) => !prevIsTestingPipeline);
-            }}
-          />
-        ) : null}
       </Form>
 
       <EuiSpacer size="m" />

x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form_fields.tsx

@@ -13,7 +13,7 @@ import { Processor } from '../../../../common/types';
 import { getUseField, getFormRow, Field, useKibana } from '../../../shared_imports';
 
 import {
-  PipelineProcessorsContextProvider,
+  ProcessorsEditorContextProvider,
   GlobalOnFailureProcessorsEditor,
   ProcessorsEditor,
   OnUpdateHandler,
@@ -29,8 +29,6 @@ interface Props {
   onLoadJson: OnDoneLoadJsonHandler;
   onProcessorsUpdate: OnUpdateHandler;
   hasVersion: boolean;
-  isTestButtonDisabled: boolean;
-  onTestPipelineClick: () => void;
   onEditorFlyoutOpen: () => void;
   isEditing?: boolean;
 }
@@ -45,8 +43,6 @@ export const PipelineFormFields: React.FunctionComponent<Props> = ({
   onProcessorsUpdate,
   isEditing,
   hasVersion,
-  isTestButtonDisabled,
-  onTestPipelineClick,
   onEditorFlyoutOpen,
 }) => {
   const { services } = useKibana();
@@ -125,20 +121,18 @@ export const PipelineFormFields: React.FunctionComponent<Props> = ({
 
       {/* Pipeline Processors Editor */}
 
-      <PipelineProcessorsContextProvider
+      <ProcessorsEditorContextProvider
         onFlyoutOpen={onEditorFlyoutOpen}
         links={{ esDocsBasePath: services.documentation.getEsDocsBasePath() }}
+        api={services.api}
+        toasts={services.notifications.toasts}
         onUpdate={onProcessorsUpdate}
         value={{ processors, onFailure }}
       >
         <div className="pipelineProcessorsEditor">
           <EuiFlexGroup gutterSize="m" responsive={false} direction="column">
             <EuiFlexItem grow={false}>
-              <ProcessorsHeader
-                onLoadJson={onLoadJson}
-                onTestPipelineClick={onTestPipelineClick}
-                isTestButtonDisabled={isTestButtonDisabled}
-              />
+              <ProcessorsHeader onLoadJson={onLoadJson} />
             </EuiFlexItem>
             <EuiFlexItem grow={false}>
               <ProcessorsEditor />
@@ -154,7 +148,7 @@ export const PipelineFormFields: React.FunctionComponent<Props> = ({
             </EuiFlexItem>
           </EuiFlexGroup>
         </div>
-      </PipelineProcessorsContextProvider>
+      </ProcessorsEditorContextProvider>
     </>
   );
 };