update filter for timeline savedObject

elastic · May 5, 2020 · 929ad24 · 929ad24
1 parent 0090d22
commit 929ad24
Showing 1 changed file with 6 additions and 13 deletions.
diff --git a/x-pack/plugins/siem/server/lib/timeline/saved_object.ts b/x-pack/plugins/siem/server/lib/timeline/saved_object.ts
@@ -98,19 +98,12 @@ export const getTimelineByTemplateTimelineId = async (
 /** The filter here is able to handle the legacy data,
  * which has no timelineType exists in the savedObject */
 const getTimelineTypeFilter = (timelineType: string | null) => {
-  if (timelineType === TimelineType.template) {
-    /** Show only whose timelineType is "template" */
-    return `siem-ui-timeline.attributes.timelineType: ${TimelineType.template}`;
-  }
-
-  if (timelineType === TimelineType.default) {
-    /** Show me every timeline whose timelineType is not "template".
-     * which includes timelineType === 'default' and
-     * those timelineType doesn't exists */
-    return `not siem-ui-timeline.attributes.timelineType: ${TimelineType.template}`;
-  }
-
-  return undefined;
+  return timelineType === TimelineType.template
+    ? `siem-ui-timeline.attributes.timelineType: ${TimelineType.template}` /** Show only whose timelineType exists and equals to "template" */
+    : /** Show me every timeline whose timelineType is not "template".
+       * which includes timelineType === 'default' and
+       * those timelineType doesn't exists */
+      `not siem-ui-timeline.attributes.timelineType: ${TimelineType.template}`;
 };
 
 export const getAllTimeline = async (