addresses comments

elastic · Mar 2, 2020 · 93f7cf0 · 93f7cf0
1 parent 5500167
commit 93f7cf0
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 21 deletions.
diff --git a/...ins/endpoint/public/applications/endpoint/view/alerts/details/metadata/host_accordion.tsx b/...ins/endpoint/public/applications/endpoint/view/alerts/details/metadata/host_accordion.tsx
@@ -21,7 +21,7 @@ export const HostAccordion = memo(({ alertData }: { alertData: Immutable<AlertDa
         title: i18n.translate('xpack.endpoint.application.endpoint.alertDetails.hostIP', {
           defaultMessage: 'Host IP',
         }),
-        description: alertData.host.ip.join(','),
+        description: alertData.host.ip.join(', '),
       },
       {
         title: i18n.translate('xpack.endpoint.application.endpoint.alertDetails.status', {

diff --git a/x-pack/plugins/endpoint/public/applications/endpoint/view/alerts/index.test.tsx b/x-pack/plugins/endpoint/public/applications/endpoint/view/alerts/index.test.tsx
@@ -140,9 +140,6 @@ describe('when on the alerting page', () => {
     it('should show the flyout', async () => {
       await render().findByTestId('alertDetailFlyout');
     });
-    it('should render resolver', async () => {
-      await render().findByTestId('alertResolver');
-    });
     describe('when the user clicks the close button on the flyout', () => {
       let renderResult: reactTestingLibrary.RenderResult;
       beforeEach(async () => {

diff --git a/x-pack/plugins/endpoint/public/applications/endpoint/view/alerts/resolver.tsx b/x-pack/plugins/endpoint/public/applications/endpoint/view/alerts/resolver.tsx
@@ -12,26 +12,22 @@ import { Resolver } from '../../../../embeddables/resolver/view';
 import { EndpointPluginServices } from '../../../../plugin';
 import { LegacyEndpointEvent } from '../../../../../common/types';
 import { storeFactory } from '../../../../embeddables/resolver/store';
-import { useAlertListSelector } from './hooks/use_alerts_selector';
-import * as selectors from '../../store/alerts/selectors';
 
 export const AlertDetailResolver = styled(
-  React.memo(({ className }: { className?: string }) => {
-    const alertDetailsData = useAlertListSelector(selectors.selectedAlertDetailsData);
-    if (alertDetailsData === undefined) {
-      return null;
-    }
-    const context = useKibana<EndpointPluginServices>();
-    const { store } = storeFactory(context);
+  React.memo(
+    ({ className, selectedEvent }: { className?: string; selectedEvent?: LegacyEndpointEvent }) => {
+      const context = useKibana<EndpointPluginServices>();
+      const { store } = storeFactory(context);
 
-    return (
-      <div className={className} data-test-subj="alertResolver" data-testid="alertResolver">
-        <Provider store={store}>
-          <Resolver selectedEvent={(alertDetailsData as unknown) as LegacyEndpointEvent} />
-        </Provider>
-      </div>
-    );
-  })
+      return (
+        <div className={className} data-test-subj="alertResolver" data-testid="alertResolver">
+          <Provider store={store}>
+            <Resolver selectedEvent={selectedEvent} />
+          </Provider>
+        </div>
+      );
+    }
+  )
 )`
   height: 100%;
   width: 100%;