[savedObjects/searchDsl/queryParams] test experimentalFilter arg

elastic · Apr 5, 2018 · 95d00d1 · 95d00d1
1 parent 255cf14
commit 95d00d1
Show file tree

Hide file tree

Showing 2 changed files with 57 additions and 1 deletion.
diff --git a/src/server/saved_objects/client/lib/search_dsl/query_params.js b/src/server/saved_objects/client/lib/search_dsl/query_params.js
@@ -88,7 +88,7 @@ export function getQueryParams(mappings, type, search, searchFields, experimenta
   }
 
   if (experimentalFilter) {
-    bool.must = (bool.must || []).concat(
+    bool.filter = (bool.filter || []).concat(
       convertExperimentalFilterToEsDsl(searchTypes, rootAttributes, experimentalFilter)
     );
   }

diff --git a/src/server/saved_objects/client/lib/search_dsl/query_params.test.js b/src/server/saved_objects/client/lib/search_dsl/query_params.test.js
@@ -61,6 +61,30 @@ describe('searchDsl/queryParams', () => {
     });
   });
 
+  describe('{type,experimentalFilter}', () => {
+    it('includes a terms filter and filters scoped to the type', () => {
+      expect(getQueryParams(MAPPINGS, 'saved', undefined, undefined, { field: 'title', value: 'foo' }))
+        .to.eql({
+          query: {
+            bool: {
+              filter: [
+                {
+                  term: { type: 'saved' }
+                },
+                {
+                  multi_match: {
+                    type: 'phrase',
+                    query: 'foo',
+                    fields: ['saved.title'],
+                  }
+                }
+              ]
+            }
+          }
+        });
+    });
+  });
+
   describe('{search}', () => {
     it('includes just a sqs query', () => {
       expect(getQueryParams(MAPPINGS, null, 'us*'))
@@ -81,6 +105,38 @@ describe('searchDsl/queryParams', () => {
     });
   });
 
+  describe('{search,experimentalFilter}', () => {
+    it('includes a sqs query and filters applying to all types', () => {
+      expect(getQueryParams(MAPPINGS, null, 'us*', undefined, { field: 'title', value: 'foo' }))
+        .to.eql({
+          query: {
+            bool: {
+              filter: [
+                {
+                  multi_match: {
+                    type: 'phrase',
+                    query: 'foo',
+                    fields: [
+                      'pending.title',
+                      'saved.title',
+                    ],
+                  }
+                }
+              ],
+              must: [
+                {
+                  simple_query_string: {
+                    query: 'us*',
+                    all_fields: true
+                  }
+                }
+              ]
+            }
+          }
+        });
+    });
+  });
+
   describe('{type,search}', () => {
     it('includes bool with sqs query and term filter for type', () => {
       expect(getQueryParams(MAPPINGS, 'saved', 'y*'))