Skip to content

Commit

Permalink
Change index-pattern text to data view (#125108)
Browse files Browse the repository at this point in the history
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
  • Loading branch information
Corey Robertson and kibanamachine committed Feb 9, 2022
1 parent 3c73b60 commit a208ae9
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion x-pack/plugins/canvas/i18n/functions/dict/escount.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const help: FunctionHelp<FunctionFactory<typeof escount>> = {
},
}),
index: i18n.translate('xpack.canvas.functions.escount.args.indexHelpText', {
defaultMessage: 'An index or index pattern. For example, {example}.',
defaultMessage: 'An index or data view. For example, {example}.',
values: {
example: '`"logstash-*"`',
},
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/canvas/i18n/functions/dict/esdocs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export const help: FunctionHelp<FunctionFactory<typeof esdocs>> = {
defaultMessage: 'A comma-separated list of fields. For better performance, use fewer fields.',
}),
index: i18n.translate('xpack.canvas.functions.esdocs.args.indexHelpText', {
defaultMessage: 'An index or index pattern. For example, {example}.',
defaultMessage: 'An index or data view. For example, {example}.',
values: {
example: '`"logstash-*"`',
},
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/canvas/i18n/ui.ts
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ export const DataSourceStrings = {
}),
getIndexLabel: () =>
i18n.translate('xpack.canvas.uis.dataSources.esdocs.indexLabel', {
defaultMessage: 'Enter an index name or select an index pattern',
defaultMessage: 'Enter an index name or select a data view',
}),
getQueryTitle: () =>
i18n.translate('xpack.canvas.uis.dataSources.esdocs.queryTitle', {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ describe('Retrieve ES Fields', () => {
routeHandler = routerDeps.router.get.mock.calls[0][1];
});

it(`returns 200 with fields from existing index/index pattern`, async () => {
it(`returns 200 with fields from existing index/data view`, async () => {
const index = 'test';
const mockResults = {
body: {
Expand Down Expand Up @@ -85,7 +85,7 @@ describe('Retrieve ES Fields', () => {
`);
});

it(`returns 200 with empty object when index/index pattern has no fields`, async () => {
it(`returns 200 with empty object when index/data view has no fields`, async () => {
const index = 'test';
const mockResults = { body: { indices: [index], fields: {} } };
const request = httpServerMock.createKibanaRequest({
Expand All @@ -107,7 +107,7 @@ describe('Retrieve ES Fields', () => {
expect(response.payload).toMatchInlineSnapshot('Object {}');
});

it(`returns 200 with empty object when index/index pattern does not have specified field(s)`, async () => {
it(`returns 200 with empty object when index/data view does not have specified field(s)`, async () => {
const index = 'test';

const mockResults = {
Expand Down

0 comments on commit a208ae9

Please sign in to comment.