Skip to content

Commit

Permalink
test: fix fn test errors
Browse files Browse the repository at this point in the history
  • Loading branch information
nickofthyme committed May 14, 2024
1 parent aa71302 commit ad8e5db
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
7 changes: 4 additions & 3 deletions test/functional/services/dashboard/panel_actions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ export class DashboardPanelActionsService extends FtrService {
}

async navigateToEditorFromFlyout() {
await this.openContextMenu();
await this.testSubjects.clickWhenNotDisabledWithoutRetry(INLINE_EDIT_PANEL_DATA_TEST_SUBJ);
await this.header.waitUntilLoadingHasFinished();
await this.testSubjects.click(EDIT_IN_LENS_EDITOR_DATA_TEST_SUBJ);
Expand All @@ -123,7 +122,8 @@ export class DashboardPanelActionsService extends FtrService {
await this.common.waitForTopNavToBeVisible();
}

/** The dashboard/canvas panels can be either edited on their editor or inline.
/**
* The dashboard/canvas panels can be either edited on their editor or inline.
* The inline editing panels allow the navigation to the editor after the flyout opens
*/
async clickEdit() {
Expand All @@ -145,7 +145,8 @@ export class DashboardPanelActionsService extends FtrService {
await this.common.waitForTopNavToBeVisible();
}

/** The dashboard/canvas panels can be either edited on their editor or inline.
/**
* The dashboard/canvas panels can be either edited on their editor or inline.
* The inline editing panels allow the navigation to the editor after the flyout opens
*/
async editPanelByTitle(title?: string) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});

it('resetting description on a by reference panel sets it to the library title', async () => {
await dashboardPanelActions.openContextMenu();
await dashboardPanelActions.navigateToEditorFromFlyout();
// legacySaveToLibrary UI cannot set description
await PageObjects.lens.save(
Expand Down

0 comments on commit ad8e5db

Please sign in to comment.