Make the success:undefined check more explicit

elastic · Apr 16, 2020 · af7b217 · af7b217
1 parent 953ff5e
commit af7b217
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/kbn-test/src/functional_test_runner/lib/suite_tracker.ts b/packages/kbn-test/src/functional_test_runner/lib/suite_tracker.ts
@@ -56,7 +56,7 @@ export class SuiteTracker {
 
   getTracked(suite: object): SuiteInProgress {
     if (!this.inProgressSuites.has(suite)) {
-      this.inProgressSuites.set(suite, {} as SuiteInProgress);
+      this.inProgressSuites.set(suite, { success: undefined } as SuiteInProgress);
     }
     return this.inProgressSuites.get(suite)!;
   }
@@ -97,7 +97,7 @@ export class SuiteTracker {
       tracked.endTime = new Date();
 
       // The suite ended without any children failing, so we can mark it as successful
-      if (!('success' in tracked)) {
+      if (typeof tracked.success === 'undefined') {
         tracked.success = true;
       }