PR fixes

elastic · Jul 12, 2021 · b3570f5 · b3570f5
1 parent 5d04948
commit b3570f5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/x-pack/plugins/alerting/server/alerts_client/alerts_client.ts b/x-pack/plugins/alerting/server/alerts_client/alerts_client.ts
@@ -184,6 +184,7 @@ export interface GetAlertInstanceSummaryParams {
   dateStart?: string;
 }
 
+// NOTE: Changing this prefix will require a migration to update the prefix in all existing `rule` saved objects
 const extractedSavedObjectParamReferenceNamePrefix = 'param:';
 
 const alertingAuthorizationFilterOpts: AlertingAuthorizationFilterOpts = {
@@ -1604,7 +1605,10 @@ export class AlertsClient {
     };
   }
 
-  private injectReferencesIntoParams<Params extends AlertTypeParams>(
+  private injectReferencesIntoParams<
+    Params extends AlertTypeParams,
+    ExtractedParams extends AlertTypeParams
+  >(
     ruleId: string,
     ruleType: UntypedNormalizedAlertType,
     ruleParams: SavedObjectAttributes | undefined,
@@ -1621,7 +1625,7 @@ export class AlertsClient {
         }));
       return ruleParams && ruleType?.useSavedObjectReferences?.injectReferences
         ? (ruleType.useSavedObjectReferences.injectReferences(
-            ruleParams,
+            ruleParams as ExtractedParams,
             paramReferences
           ) as Params)
         : (ruleParams as Params);

diff --git a/x-pack/plugins/alerting/server/types.ts b/x-pack/plugins/alerting/server/types.ts
@@ -154,7 +154,7 @@ export interface AlertType<
   minimumLicenseRequired: LicenseType;
   useSavedObjectReferences?: {
     extractReferences: (params: Params) => RuleParamsAndRefs<ExtractedParams>;
-    injectReferences: (params: SavedObjectAttributes, references: SavedObjectReference[]) => Params;
+    injectReferences: (params: ExtractedParams, references: SavedObjectReference[]) => Params;
   };
   isExportable: boolean;
 }